Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure-installer-tests-cluster-ppc64le to support nodejs12 e2e test #4229

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

sarveshtamba
Copy link
Contributor

Update configure-installer-tests-cluster-ppc64le to support nodejs12 e2e test

What type of PR is this?
/kind bug
/kind feature

What does does this PR do / why we need it:
Make conformance with PR #4070 and #4215

Which issue(s) this PR fixes:

Fixes #4016

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Latest nodejs image on 4.6 should work fine for odo

…e2e test

Update configure-installer-tests-cluster-ppc64le to support nodejs12 e2e test
@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Nov 17, 2020
@openshift-ci-robot
Copy link
Collaborator

Hi @sarveshtamba. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sarveshtamba
Copy link
Contributor Author

@kadel similar to #4215 can you please approve this PR as well?

@sarveshtamba
Copy link
Contributor Author

/area system-pz

@openshift-ci-robot openshift-ci-robot added the area/System-PZ Issues related to IBM System Z and System P label Nov 17, 2020
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #4229 (f57955c) into master (2363910) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4229   +/-   ##
=======================================
  Coverage   42.56%   42.56%           
=======================================
  Files         156      156           
  Lines       13266    13266           
=======================================
  Hits         5647     5647           
  Misses       7017     7017           
  Partials      602      602           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2363910...f57955c. Read the comment docs.

@kadel
Copy link
Member

kadel commented Nov 18, 2020

/approve
/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Nov 18, 2020
@sarveshtamba
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Collaborator

@sarveshtamba: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kadel
Copy link
Member

kadel commented Nov 19, 2020

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Nov 19, 2020
@sarveshtamba
Copy link
Contributor Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@sarveshtamba
Copy link
Contributor Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@kadel
Copy link
Member

kadel commented Nov 19, 2020

/override Travis CI - Pull Request

@openshift-ci-robot
Copy link
Collaborator

@kadel: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • Travis CI - Pull Request

Only the following contexts were expected:

  • ci/prow/unit
  • ci/prow/v4.5-integration-e2e
  • tide

In response to this:

/override Travis CI - Pull Request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kadel
Copy link
Member

kadel commented Nov 19, 2020

/override ci/prow/v4.5-integration-e2e

@openshift-ci-robot
Copy link
Collaborator

@kadel: Overrode contexts on behalf of kadel: ci/prow/v4.5-integration-e2e

In response to this:

/override ci/prow/v4.5-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kadel
Copy link
Member

kadel commented Nov 19, 2020

/refresh

@kadel
Copy link
Member

kadel commented Nov 19, 2020

/override tide

@openshift-ci-robot
Copy link
Collaborator

@kadel: Overrode contexts on behalf of kadel: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@kadel kadel merged commit 2e8304e into redhat-developer:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/System-PZ Issues related to IBM System Z and System P kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odo create --s2i flag shows Warning message on 4.6 cluster
4 participants