-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors, cleans and moves some resources to the new files. #4250
Refactors, cleans and moves some resources to the new files. #4250
Conversation
9997e0d
to
f75df8d
Compare
Signed-off-by: mik-dass <mrinald7@gmail.com>
f75df8d
to
834186d
Compare
Looks good |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Signed-off-by: mik-dass mrinald7@gmail.com
What type of PR is this?
/kind cleanup
/kind code-refactoring
What does does this PR do / why we need it:
Refactors, cleans and moves some resources to the new files. It also adds unit tests for some functions.
Which issue(s) this PR fixes:
Fixes part of #4093
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer: