Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language and projectType metadata in devfile for s2i components #4911

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Add language and projectType metadata in devfile for s2i components #4911

merged 1 commit into from
Jul 23, 2021

Conversation

valaparthvi
Copy link
Member

@valaparthvi valaparthvi commented Jul 13, 2021 •
edited

What type of PR is this?
/kind bug
What does this PR do / why we need it:
This PR adds user-provided component name to devfile metadata for normal component creation and language to devfile metadata for s2i creation.

Which issue(s) this PR fixes:

Fixes #4816

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

  • Update changelog

  • I have read the test guidelines

How to test changes / Special notes to the reviewer:

  1. Create a s2i component and check if .metadata.language and .metadata.projectType is set properly in the devfile.yaml. odo create --s2i nodejs mynodecomp.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 13, 2021
@openshift-ci openshift-ci bot requested review from dharmit and mik-dass July 13, 2021 13:13
@valaparthvi valaparthvi changed the title Fix devfile metadata during component creation WIP: Fix devfile metadata during component creation Jul 13, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 13, 2021
@valaparthvi
Copy link
Member Author

/retest

@valaparthvi
Copy link
Member Author

/test psi-kubernetes-integration-e2e

"kubernetes-integration-e2e" test steps failed: ["kubernetes-integration-e2e" pod "kubernetes-integration-e2e-kubernetes-integration-e2e-steps" failed: context canceled
Link to step on registry info site: https://steps.ci.openshift.org/reference/kubernetes-integration-e2e-steps
Link to job on registry info site: https://steps.ci.openshift.org/job?org=openshift&repo=odo&branch=main&test=kubernetes-integration-e2e&variant=psi, cancelled]

@valaparthvi valaparthvi changed the title WIP: Fix devfile metadata during component creation Fix devfile metadata during component creation Jul 19, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 19, 2021
@valaparthvi valaparthvi changed the title Fix devfile metadata during component creation WIP:Fix devfile metadata during component creation Jul 21, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 21, 2021
@valaparthvi valaparthvi changed the title WIP:Fix devfile metadata during component creation Fix devfile metadata during component creation Jul 21, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 21, 2021
@valaparthvi valaparthvi changed the title Fix devfile metadata during component creation Add language and projectType metadata in devfile for s2i components Jul 21, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.3% 6.3% Duplication

@valaparthvi
Copy link
Member Author

/retest



  | 3h57m28s
-- | --
"kubernetes-integration-e2e" test steps failed: ["kubernetes-integration-e2e" pod "kubernetes-integration-e2e-kubernetes-integration-e2e-steps" failed: context canceled Link to step on registry info site: https://steps.ci.openshift.org/reference/kubernetes-integration-e2e-steps Link to job on registry info site: https://steps.ci.openshift.org/job?org=openshift&repo=odo&branch=main&test=kubernetes-integration-e2e&variant=psi, cancelled]

@prietyc123
Copy link
Contributor

/test psi-kubernetes-integration-e2e

mik-dass
mik-dass approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 23, 2021
@feloy
Copy link
Contributor

feloy commented Jul 23, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 23, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2021 •
edited

@valaparthvi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/psi-kubernetes-integration-e2e f2afca4 link /test psi-kubernetes-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@valaparthvi
Copy link
Member Author

/retest-required

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a8f78ae into redhat-developer:main Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-dass mik-dass mik-dass approved these changes

@dharmit dharmit Awaiting requested review from dharmit

Assignees

@mik-dass mik-dass

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo create --s2i should set .metadata.language in devfile.yaml
6 participants
@valaparthvi @prietyc123 @feloy @openshift-bot @mik-dass @openshift-merge-robot