Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devfile push test refactor #4924

Merged
merged 11 commits into from
Aug 26, 2021
Merged

devfile push test refactor #4924

merged 11 commits into from
Aug 26, 2021

Conversation

anandrkskd
Copy link
Contributor

@anandrkskd anandrkskd commented Jul 20, 2021 •
edited

What type of PR is this?

/kind code-refactoring

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #4878

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

  • Update changelog

  • I have read the test guidelines

How to test changes / Special notes to the reviewer:

@anandrkskd
refactor odo devfile push test
fff16eb 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
first context
a0ad9e1 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
feloy
feloy reviewed Jul 20, 2021
View reviewed changes
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
@anandrkskd
improved test discription
f014f7d 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
updated tests
8d44243 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
fixed failing tests
9c2087e 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
remove FIt
6f0cc0b 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
fix test
84947ce 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@feloy
Copy link
Contributor

feloy commented Jul 23, 2021

There are some remaining JustBeforeEach. Please replace them with BeforeEach

@anandrkskd
add better discription
883b57b 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
Copy link
Contributor Author

/retest

@anandrkskd
Copy link
Contributor Author

/test psi-unit-test-windows

@anandrkskd
Copy link
Contributor Author

/retest

1 similar comment
@anandrkskd
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2021 •
edited

@anandrkskd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/v4.7-integration-e2e 883b57b link /test v4.7-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anandrkskd
Copy link
Contributor Author

/test psi-kubernetes-integration-e2e

@prietyc123
Copy link
Contributor

@anandrkskd I would suggest #4924 (comment) for entire file. Could you please have a look. Correct me if I am wrong.

@anandrkskd
typo resolved
6128d9a 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@prietyc123
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 23, 2021
feloy
feloy reviewed Aug 23, 2021
View reviewed changes
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_push_test.go Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_push_test.go Outdated Show resolved Hide resolved
@anandrkskd
breaking down tests into smaller chunk
3714ac7 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 24, 2021
@anandrkskd
update test
93c93c5 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 8 Code Smells

No Coverage information No Coverage information
7.6% 7.6% Duplication

@feloy
Copy link
Contributor

feloy commented Aug 25, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 25, 2021
@prietyc123
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit b3bdb34 into redhat-developer:main Aug 26, 2021
@kadel kadel added area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/code-refactoring and removed kind/code-refactoring labels Sep 7, 2021
@kadel kadel mentioned this pull request Sep 7, 2021
Merged
@anandrkskd anandrkskd deleted the tests/devfile-push-refactor branch October 13, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy left review comments

@prietyc123 prietyc123 prietyc123 requested changes

@dharmit dharmit Awaiting requested review from dharmit

Assignees

@prietyc123 prietyc123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor tests for test-cmd-devfile-push
5 participants
@anandrkskd @feloy @prietyc123 @kadel @openshift-merge-robot