Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup namespaces #4985

Merged
merged 16 commits into from
Sep 3, 2021
Merged

Cleanup namespaces #4985

merged 16 commits into from
Sep 3, 2021

Conversation

anandrkskd
Copy link
Contributor

@anandrkskd anandrkskd commented Aug 12, 2021 •
edited

What type of PR is this?

/kind cleanup

What does this PR do / why we need it:

This PR adds a script to cleanup namespace that are x days old from the cluster, as well as adds helper functions to support the cleanup process

Which issue(s) this PR fixes:

Fixes #4467

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

  • Update changelog

  • I have read the test guidelines

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/cleanup labels Aug 12, 2021
@netlify
Copy link

netlify bot commented Aug 12, 2021 •
edited

✔️ Deploy Preview for odo-docusaurus-preview ready!

🔨 Explore the source changes: eb2b2fc

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/612725bc14ed8a000843b1e9

😎 Browse the preview: https://deploy-preview-4985--odo-docusaurus-preview.netlify.app

@dharmit
Copy link
Member

dharmit commented Aug 16, 2021

Please update the Changelog.md.

@anandrkskd
Copy link
Contributor Author

/test v4.8-integration-e2e

@dharmit
Copy link
Member

dharmit commented Aug 17, 2021

@anandrkskd is this still WIP?

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Aug 18, 2021
@anandrkskd
Script for cleaning projects
1c5c914 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
adding script,function for cleaning projects
5af1286 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
generify function
33f7836 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Aug 18, 2021
@anandrkskd anandrkskd changed the title [WIP] Cleanup namespaces Cleanup namespaces Aug 18, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 18, 2021
dharmit
dharmit suggested changes Aug 18, 2021
View reviewed changes
scripts/CleanCluster.sh Outdated Show resolved Hide resolved
scripts/CleanCluster.sh Outdated Show resolved Hide resolved
scripts/CleanCluster.sh Outdated Show resolved Hide resolved
scripts/CleanCluster.sh Outdated Show resolved Hide resolved
scripts/CleanCluster.sh Outdated Show resolved Hide resolved
scripts/CleanCluster.sh Outdated Show resolved Hide resolved
tests/helper/helper_oc.go Show resolved Hide resolved
@anandrkskd
updated with comment
18e5c1c 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
dharmit
dharmit suggested changes Aug 19, 2021
View reviewed changes
scripts/clean-old-namespace-from-cluster.sh Outdated Show resolved Hide resolved
scripts/clean-old-namespace-from-cluster.sh Outdated Show resolved Hide resolved
@dharmit dharmit requested a review from feloy August 19, 2021 07:30
@dharmit
Copy link
Member

dharmit commented Aug 19, 2021

@feloy I've requested for your review on this because we need to help @anandrkskd get this merged sooner rather than later. Moving to IBM Cloud is not going to be worth much if the problem addressed by this PR isn't fixed.

feloy
feloy reviewed Aug 19, 2021
View reviewed changes
scripts/clean-old-namespace-from-cluster.sh Outdated Show resolved Hide resolved
scripts/clean-old-namespace-from-cluster.sh Outdated Show resolved Hide resolved
tests/helper/helper_oc.go Outdated Show resolved Hide resolved
tests/helper/helper_oc.go Outdated Show resolved Hide resolved
@anandrkskd
update script and use ioutil.writefile
92a04aa 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
file permission change to 0600
2bc6d42 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
Copy link
Contributor Author

/retest

dharmit
dharmit reviewed Aug 23, 2021
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 23, 2021
@anandrkskd
add labels and label checks
f5d2d12 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
add team check for cleanup
df0f27c 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
feloy
feloy reviewed Sep 1, 2021
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an unused line to remove, and that seems ok to me

tests/helper/helper_kubectl.go Outdated Show resolved Hide resolved
@anandrkskd
remove namespace labeling
387cd5f 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@feloy
Copy link
Contributor

feloy commented Sep 1, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 1, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Sep 2, 2021
@anandrkskd
rebase
7fee700 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 2, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Sep 2, 2021
@feloy
Copy link
Contributor

feloy commented Sep 2, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 2, 2021
@anandrkskd
fix lint error
8043452 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 2, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@feloy
Copy link
Contributor

feloy commented Sep 2, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 2, 2021
@anandrkskd
Copy link
Contributor Author

/test psi-kubernetes-integration-e2e

@openshift-merge-robot openshift-merge-robot merged commit 74f63b9 into redhat-developer:main Sep 3, 2021
@kadel kadel mentioned this pull request Sep 7, 2021
Merged
@anandrkskd anandrkskd deleted the test/cleanup branch October 13, 2022 11:12
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel kadel left review comments

@dharmit dharmit dharmit requested changes

@feloy feloy feloy left review comments

@prietyc123 prietyc123 prietyc123 left review comments

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@dharmit dharmit

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests are not cleaning up projects/namespaces.
9 participants
@anandrkskd @dharmit @feloy @mohammedzee1000 @openshift-bot @kadel @prietyc123 @rm3l @openshift-merge-robot