Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed QE members from top-level reviewers #5009

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Removed QE members from top-level reviewers #5009

merged 2 commits into from
Aug 20, 2021

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Aug 19, 2021

/kind cleanup

What does this PR do / why we need it:
To ensure right folks get selected by the bot for reviews

Which issue(s) this PR fixes:

Fixes - NA

@dharmit
Update OWNERS
8101a12 
Removed QE members from top-level reviewers
@valaparthvi
Copy link
Member

What about reviewing files from the tests dir? The OWNER file in tests does not have any reviewer, would QE be assigned to review changes made to tests?

@dharmit
Copy link
Member Author

dharmit commented Aug 19, 2021

What about reviewing files from the tests dir? The OWNER file in tests does not have any reviewer, would QE be assigned to review changes made to tests?

Yeah, they could be.

@dharmit
Update OWNERS
bf9ab49 
Updates tests OWNERS
@dharmit
Copy link
Member Author

dharmit commented Aug 19, 2021

@valaparthvi updated. PTAL.

@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rnapoles-rh
rnapoles-rh reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor

@rnapoles-rh rnapoles-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 19, 2021
@valaparthvi
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: valaparthvi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3642d17 into main Aug 20, 2021
@kadel kadel mentioned this pull request Sep 7, 2021
Merged
@dharmit dharmit deleted the update-owners branch September 28, 2021 05:26
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnapoles-rh rnapoles-rh rnapoles-rh left review comments

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@rnapoles-rh rnapoles-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dharmit @valaparthvi @rnapoles-rh @rm3l @openshift-merge-robot