Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes code related to s2i storage #5021

Merged
merged 3 commits into from
Sep 3, 2021
Merged

Removes code related to s2i storage #5021

merged 3 commits into from
Sep 3, 2021

Conversation

mik-dass
Copy link
Contributor

@mik-dass mik-dass commented Aug 25, 2021 •
edited

What type of PR is this?

/kind cleanup

What does this PR do / why we need it:

It removes code related to the s2i storage.

Which issue(s) this PR fixes:

Fixes part of #4932

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

Tests should pass.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/cleanup labels Aug 25, 2021
@openshift-ci openshift-ci bot requested review from dharmit and feloy August 25, 2021 10:42
@mik-dass mik-dass force-pushed the delete_s2i_storage branch 5 times, most recently from 29cca2a to 9f0b5a7 Compare August 26, 2021 11:18
@mik-dass mik-dass changed the title [WIP] Removes code related to s2i storage Removes code related to s2i storage Aug 27, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 27, 2021
@valaparthvi
Copy link
Member

This might overlap with @feloy's #4948. Ignore this if you are already aware 🙌

@valaparthvi valaparthvi mentioned this pull request Aug 27, 2021
Merged
17 tasks
valaparthvi
valaparthvi suggested changes Aug 30, 2021
View reviewed changes
Copy link
Member

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for most of the PR, thank you for the changes!

pkg/component/pushed_component.go Show resolved Hide resolved
pkg/component/pushed_component.go Show resolved Hide resolved
pkg/component/pushed_component.go Show resolved Hide resolved
pkg/component/pushed_component.go Outdated Show resolved Hide resolved
pkg/odo/cli/component/component.go Show resolved Hide resolved
pkg/storage/utils_test.go Outdated Show resolved Hide resolved
pkg/storage/utils_test.go Show resolved Hide resolved
pkg/storage/kubernetes.go Show resolved Hide resolved
pkg/storage/kubernetes.go Outdated Show resolved Hide resolved
pkg/component/component.go Show resolved Hide resolved
feloy
feloy reviewed Sep 1, 2021
View reviewed changes
pkg/component/pushed_component.go Show resolved Hide resolved
pkg/storage/kubernetes.go Outdated Show resolved Hide resolved
@mik-dass mik-dass force-pushed the delete_s2i_storage branch 2 times, most recently from c4f1bda to 29995c8 Compare September 2, 2021 06:30
@valaparthvi
Copy link
Member

The code lgtm, but since @feloy has some concerns, I'll wait on marking this as lgtm.

@feloy
Copy link
Contributor

feloy commented Sep 2, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 2, 2021
@valaparthvi
Copy link
Member

/lgtm

/approve(#5021 (comment))

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 2, 2021
@valaparthvi
Copy link
Member

/retest-required

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@valaparthvi
Copy link
Member

@mik-dass Can you resolve the merge conflict?

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Sep 3, 2021
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. Required by Prow. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. labels Sep 3, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@valaparthvi
Copy link
Member

@mik-dass Just to make sure I got it right, you removed the unit tests from utils_test.go because Philippe's #4948 got merged, right?

@valaparthvi
Copy link
Member

/lgtm

@mik-dass
Copy link
Contributor Author

mik-dass commented Sep 3, 2021

@mik-dass Just to make sure I got it right, you removed the unit tests from utils_test.go because Philippe's #4948 got merged, right?

Yes

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit 9e05d1b into redhat-developer:main Sep 3, 2021
@mik-dass mik-dass deleted the delete_s2i_storage branch September 3, 2021 10:33
@kadel kadel mentioned this pull request Sep 7, 2021
Merged
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy left review comments

@valaparthvi valaparthvi valaparthvi requested changes

@dharmit dharmit Awaiting requested review from dharmit

Assignees

@valaparthvi valaparthvi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mik-dass @valaparthvi @feloy @openshift-bot @rm3l @openshift-merge-robot