Modifies and adds scripts to run K8S tests on IBM Cloud cluster #5022
Conversation
…rewall not taking parameters for script execution
|
✔️ Deploy Preview for odo-docusaurus-preview ready! 🔨 Explore the source changes: 684cbde 🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6126242ce5bc650008d6b99b 😎 Browse the preview: https://deploy-preview-5022--odo-docusaurus-preview.netlify.app |
| # Integration tests | ||
| shout "| Running integration Tests on Kubernetes cluster in IBM Cloud" | ||
| make test-cmd-project | ||
| make test-integration-devfile |
There was a problem hiding this comment.
So we're going to enable only these two test targets in the first pass? Rest to follow later?
There was a problem hiding this comment.
Yes, that is because those two test suites pass OK when I run them manually against the K8S cluster in the IBM Cloud, others have some failures. As agreed we are enabling only those that pass and then will add others as fixes become available.
There was a problem hiding this comment.
Looks like you removed test-integration-devfile. It isn't working well any more? 😞
There was a problem hiding this comment.
Looks like you removed
test-integration-devfile. It isn't working well any more? 😞
yes, some failures in test-integration-devfile again
There was a problem hiding this comment.
@prietyc123 @anandrkskd feel free to remove LGTM label. I'm approving it so that on GH interface it doesn't show as pending on my requested changes.
openshift-ci
bot
added
the
lgtm
openshift-ci
bot
removed
the
lgtm
|
@prietyc123 changed ifeq statement with ifdef as suggested |
Makefile
Outdated
| @@ -18,7 +18,11 @@ TIMEOUT ?= 14400s | |||
| # TEST_EXEC_NODES=1, otherwise by default the specs are run in parallel on 4 ginkgo test node. | |||
There was a problem hiding this comment.
@rnapoles-rh Could you please add IBM cluster test node info in the comment as well.
|
other than #5022 (comment) everything looks good to me. @rnapoles-rh once the changes being done, will add lgtm to this pr. Meanwhile adding approve label. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prietyc123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
There was a problem hiding this comment.
other than #5022 (comment) everything looks good to me. @rnapoles-rh once the changes being done, will add lgtm to this pr. Meanwhile adding approve label.
/approve
@prietyc123 added comment in Makefile as per request
|
SonarCloud Quality Gate failed.
|
| @@ -14,6 +14,7 @@ SCRIPT_IDENTITY=${SCRIPT_IDENTITY:-"def-id"} | |||
|
|
|||
| case ${1} in | |||
| k8s) | |||
| export TEST_EXEC_NODES="24" | |||
There was a problem hiding this comment.
Does that mean, you don't set any value on jenkins?
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
What type of PR is this?
/kind tests
What does this PR do / why we need it:
To run test in IBM Cloud cluster
Which issue(s) this PR fixes:
Fixes #4798
PR acceptance criteria:
How to test changes / Special notes to the reviewer: