Debug test file cleanup left over #5038
Conversation
openshift-ci
bot
added
kind/tests
needs-rebase
|
✔️ Deploy Preview for odo-docusaurus-preview ready! 🔨 Explore the source changes: 6bfc8aa 🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6131a6f9a0bf5f00075477cf 😎 Browse the preview: https://deploy-preview-5038--odo-docusaurus-preview.netlify.app |
prietyc123
force-pushed
the
CleanupDebugJsonLeftOutFromTest
branch
from
096456f
to
6bfc8aa
Compare
openshift-ci
bot
removed
the
needs-rebase
tests/helper/helper_generic.go
Outdated
| @@ -328,7 +328,7 @@ func CommonAfterEach(commonVar CommonVar) { | |||
| func GjsonMatcher(values []gjson.Result, expected []string) bool { | |||
| matched := 0 | |||
| for i, v := range values { | |||
| if strings.Contains(v.String(), expected[i]) { | |||
| if CaseInsensitiveStringContains(v.String(), expected[i]) { | |||
There was a problem hiding this comment.
This method is used in a lot of places, are we sure we never want to test for case in any of these tests?
There was a problem hiding this comment.
I added such workaround for #5037 . I think it does not make sense after your comment #5037 (comment)
prietyc123
force-pushed
the
CleanupDebugJsonLeftOutFromTest
branch
2 times, most recently
from
3b08e07
to
8d76854
Compare
prietyc123
changed the title
|
@prietyc123 I see you closed the issue #5037, does that mean this PR is not relevant anymore? |
prietyc123
force-pushed
the
CleanupDebugJsonLeftOutFromTest
branch
from
c9fb9bd
to
9273142
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
@valaparthvi This pr is still relevant to remove |
|
/retest |
|
kuberenetes job was waiting for a long time in queue and then failed. /test psi-kubernetes-integration-e2e |
|
/approve /lgtm |
openshift-ci
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
What type of PR is this?
/kind tests
What does this PR do / why we need it:
This pr will remove the
tmpdirectory debug test data leftover and also a workaround for #5037 in testsWhich issue(s) this PR fixes:
Fixes #?
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
make test-cmd-devfile-storageshould not throw error in #5037