repeated check for deleted dir in odo watch test #5058
Conversation
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
openshift-ci
bot
added
the
flake
|
✔️ Deploy Preview for odo-docusaurus-preview ready! 🔨 Explore the source changes: 5a15a89 🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6139d2313284260007225b24 😎 Browse the preview: https://deploy-preview-5058--odo-docusaurus-preview.netlify.app |
|
/test psi-unit-test-mac |
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
| switch platform { | ||
| case "kube": | ||
| if isDevfileTest { | ||
| folderToCheck := "/projects" | ||
| folderToCheck = "/projects" | ||
| if odoV2Watch.FolderToCheck != "" { | ||
| folderToCheck = odoV2Watch.FolderToCheck | ||
| } | ||
| cliRunner := runner.(helper.CliRunner) |
There was a problem hiding this comment.
I think you missed removing cliRunner from here, no?
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
/test v4.8-integration-e2e |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prietyc123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/kind test |
|
@anandrkskd: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind tests |
Signed-off-by: anandrkskd anandrkskd@gmail.com
What type of PR is this?
/kind flake
What does this PR do / why we need it:
This Pr fixes flake for odo watch test
Which issue(s) this PR fixes:
Fixes #5044
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer: