Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timezone information to Telemetry data #5067

Merged
merged 3 commits into from
Sep 24, 2021
Merged

Add timezone information to Telemetry data #5067

merged 3 commits into from
Sep 24, 2021

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Sep 13, 2021 •
edited

What type of PR is this?
/kind feature

What does this PR do / why we need it:
$subject

Which issue(s) this PR fixes:

Fixes part of #4994

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Segment data should contain the timezone information in the format "UTC +0530", "UTC 0000", etc.

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Sep 13, 2021
@dharmit dharmit requested review from kadel and removed request for mohammedzee1000 September 13, 2021 11:34
@dharmit dharmit mentioned this pull request Sep 14, 2021
Closed
2 tasks
@feloy
Copy link
Contributor

feloy commented Sep 15, 2021

/lgtm

@feloy
Copy link
Contributor

feloy commented Sep 15, 2021

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 15, 2021
@feloy
Copy link
Contributor

feloy commented Sep 15, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Sep 15, 2021
@feloy feloy removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Sep 15, 2021
@dharmit dharmit mentioned this pull request Sep 15, 2021
Merged
4 tasks
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. and removed lgtm Indicates that a PR is ready to be merged. Required by Prow. labels Sep 15, 2021
feloy
feloy reviewed Sep 15, 2021
View reviewed changes
pkg/segment/segment.go Outdated Show resolved Hide resolved
@dharmit @feloy
Update pkg/segment/segment.go
0ee5d10 
Co-authored-by: Philippe Martin <contact@elol.fr>
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2021 •
edited

@dharmit: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/psi-k8s-ibmc-integration-e2e 0ee5d10 link /test psi-k8s-ibmc-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feloy
Copy link
Contributor

feloy commented Sep 24, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6496096 into redhat-developer:main Sep 24, 2021
@dharmit dharmit deleted the fix-4994-tz branch September 28, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy left review comments

@kadel kadel Awaiting requested review from kadel

Assignees

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dharmit @feloy @openshift-merge-robot