Removing unused flags in link command

[mohammedzee1000]

What type of PR is this?
/kind cleanup

What does this PR do / why we need it:
See title

Which issue(s) this PR fixes:

Fixes #4889

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

• I have read the test guidelines

How to test changes / Special notes to the reviewer:
WIP

[feloy]

As an envSpecificInfo is now expected in all cases, you could write instead:

if o.Context.EnvSpecificInfo == nil {
		return fmt.Errorf("failed to find environment info")
}

return o.completeForOperator()

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.3% Duplication

[mohammedzee1000]

[ssh:Fedora-32-minikube] ------------------------------
[ssh:Fedora-32-minikube] • Failure in Spec Setup (BeforeEach) [6.293 seconds]
[ssh:Fedora-32-minikube] odo devfile push command tests
[ssh:Fedora-32-minikube] /home/fedora/amqp_ci_rcv_odo-minikube-pr-build_PR_5070/LoIpj/repo/tests/integration/devfile/cmd_devfile_push_test.go:18
[ssh:Fedora-32-minikube]   when creating a nodejs component
[ssh:Fedora-32-minikube]   /home/fedora/amqp_ci_rcv_odo-minikube-pr-build_PR_5070/LoIpj/repo/tests/integration/devfile/cmd_devfile_push_test.go:35
[ssh:Fedora-32-minikube]     when project and clonePath is present in devfile and doing odo push [BeforeEach]
[ssh:Fedora-32-minikube]     /home/fedora/amqp_ci_rcv_odo-minikube-pr-build_PR_5070/LoIpj/repo/tests/integration/devfile/cmd_devfile_push_test.go:245
[ssh:Fedora-32-minikube]       should sync to the correct dir in container
[ssh:Fedora-32-minikube]       /home/fedora/amqp_ci_rcv_odo-minikube-pr-build_PR_5070/LoIpj/repo/tests/integration/devfile/cmd_devfile_push_test.go:253
[ssh:Fedora-32-minikube] 
[ssh:Fedora-32-minikube]       No future change is possible.  Bailing out early after 0.235s.
      
[ssh:Fedora-32-minikube]       Running odo with args [odo create nodejs --project cmd-devfile-push-test253rln smeatl]
[ssh:Fedora-32-minikube]       Expected
[ssh:Fedora-32-minikube]           <int>: 1
[ssh:Fedora-32-minikube]       to match exit code:
[ssh:Fedora-32-minikube]           <int>: 0
[ssh:Fedora-32-minikube] 
[ssh:Fedora-32-minikube]       /home/fedora/amqp_ci_rcv_odo-minikube-pr-build_PR_5070/LoIpj/repo/tests/helper/helper_cmd_wrapper.go:99
[ssh:Fedora-32-minikube] ------------------------------
[ssh:Fedora-32-minikube] •

fail seems unrelated to changes
/retest

[openshift-ci]

@mohammedzee1000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/psi-k8s-ibmc-integration-e2e	e139de9	link	false	/test psi-k8s-ibmc-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[feloy]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [feloy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.