Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor devfile-url test #5102

Conversation

anandrkskd
Copy link
Contributor

Signed-off-by: anandrkskd anandrkskd@gmail.com

What type of PR is this?
/kind code-refactoring
/kind tests

What does this PR do / why we need it:
This PR refactors the test to use the new test flow

Which issue(s) this PR fixes:

Fixes #5051

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
make test-cmd-devfile-url should pass

Signed-off-by: anandrkskd <anandrkskd@gmail.com>
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@netlify
Copy link

netlify bot commented Sep 30, 2021

✔️ Deploy Preview for odo-docusaurus-preview ready!

🔨 Explore the source changes: b4c4052

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6155920ef1072700080e6c9d

😎 Browse the preview: https://deploy-preview-5102--odo-docusaurus-preview.netlify.app

@anandrkskd
Copy link
Contributor Author

@feloy, @valaparthvi can you give early review for this PR?

Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
Copy link
Contributor Author

/retest

Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
Copy link
Contributor Author

/test v4.8-integration-e2e

Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 👍
Just some suggestions on descriptions

tests/integration/devfile/cmd_devfile_url_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_url_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_url_test.go Outdated Show resolved Hide resolved
tests/integration/devfile/cmd_devfile_url_test.go Outdated Show resolved Hide resolved
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
Copy link
Contributor Author

@feloy I have pushed the changes you suggested. :)

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.1% 5.1% Duplication

@anandrkskd
Copy link
Contributor Author

/test psi-kubernetes-integration-e2e

@feloy
Copy link
Contributor

feloy commented Oct 6, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 6, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@anandrkskd
Copy link
Contributor Author

/test v4.8-integration-e2e

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2021

@anandrkskd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/psi-k8s-ibmc-integration-e2e c0bb288 link false /test psi-k8s-ibmc-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f1603a2 into redhat-developer:main Oct 6, 2021
@anandrkskd anandrkskd deleted the tests/devfile-url-refactor branch October 13, 2022 11:12
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor test-cmd-devfile-url tests
5 participants