Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DefaultDevfileRegistry link in IBM-Z and Power doc #5103

Conversation

xkwangcn
Copy link
Contributor

@xkwangcn xkwangcn commented Sep 30, 2021

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind feature
/kind cleanup
/kind tests
/kind documentation
Feel free to use other labels as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.

What does this PR do / why we need it:

In doc: https://odo.dev/docs/tutorials/deploying-a-devfile-using-odo-on-ibm-z-and-power/#deploying-your-first-devfile-on-ibm-z--power, DefaultDevfileRegistry use old link https://github.com/odo-devfiles/registry, need update it to https://registry.devfile.io/viewer
Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Sep 30, 2021

✔️ Deploy Preview for odo-docusaurus-preview ready!

🔨 Explore the source changes: 13d2ae2

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/61554f8e8dbe4e000829aa4a

😎 Browse the preview: https://deploy-preview-5103--odo-docusaurus-preview.netlify.app

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@xkwangcn
Copy link
Contributor Author

/area system-PZ

@openshift-ci openshift-ci bot added the area/System-PZ Issues related to IBM System Z and System P label Sep 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

Hi @xkwangcn. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Sep 30, 2021
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7ed1b22 into redhat-developer:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/System-PZ Issues related to IBM System Z and System P lgtm Indicates that a PR is ready to be merged. Required by Prow. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants