Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit calls to devfile registry #5126

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Limit calls to devfile registry #5126

merged 1 commit into from
Oct 8, 2021

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Oct 6, 2021

What type of PR is this?

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #5116

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 6, 2021
@feloy feloy changed the title Limit calls to devfile registry WIP: Limit calls to devfile registry Oct 6, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 6, 2021
@feloy feloy force-pushed the bugfix-5116/dont-call-devfile-registry branch 3 times, most recently from 5760e0a to edd1856 Compare October 7, 2021 12:36
@netlify
Copy link

netlify bot commented Oct 7, 2021 •
edited

✔️ Deploy Preview for odo-docusaurus-preview ready!

🔨 Explore the source changes: 9e326ad

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/615fe941d45ecc00084dc9a3

😎 Browse the preview: https://deploy-preview-5126--odo-docusaurus-preview.netlify.app

@feloy feloy changed the title WIP: Limit calls to devfile registry Limit calls to devfile registry Oct 7, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 7, 2021
@feloy feloy requested review from valaparthvi and removed request for prietyc123 October 7, 2021 16:53
@feloy feloy force-pushed the bugfix-5116/dont-call-devfile-registry branch from 7847aec to 9e326ad Compare October 8, 2021 06:46
@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
4.9% 4.9% Duplication

@kadel
Copy link
Member

kadel commented Oct 8, 2021

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Oct 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8c630b5 into redhat-developer:main Oct 8, 2021
@feloy feloy mentioned this pull request Oct 12, 2021
Closed
feloy added a commit to feloy/odo that referenced this pull request Oct 15, 2021
@feloy
Min use of devfile.io for integration tests (redhat-developer#5126)
7a43673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@kadel kadel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protocol error during tests
3 participants
@feloy @kadel @openshift-merge-robot