Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup resources from integration tests #5135

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Cleanup resources from integration tests #5135

merged 2 commits into from
Oct 11, 2021

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Oct 11, 2021

What type of PR is this?
/kind tests

What does this PR do / why we need it:

  • Cleanup from integration tests:
    • a remaining namespace
    • a remaining deployment on default namespace
  • Changes Out() to Err() in an integration test to make it pass on IBM pipeline / GitHub Actions

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anandrkskd
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 11, 2021
@feloy
Copy link
Contributor Author

feloy commented Oct 11, 2021

/test psi-unit-test-windows

@feloy
Copy link
Contributor Author

feloy commented Oct 11, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6d2ab82 into redhat-developer:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@anandrkskd anandrkskd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@feloy @anandrkskd @openshift-merge-robot