Remove submodules #423
Remove submodules #423
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
vrutkovs
force-pushed
the
remove-fedora-coreos-submodule
branch
from
4854f2e
to
4131205
Compare
gcp-routes can be copied from openshift-os image
This is already provided by /usr/lib/NetworkManager/conf.d/20-client-id-from-mac.conf
vrutkovs
force-pushed
the
remove-fedora-coreos-submodule
branch
from
4131205
to
a34a807
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/override ci/prow/e2e-gcp-upgrade Previous build could not be installed /test e2e-aws-ovn |
|
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-gcp-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
| @@ -1,5 +1,6 @@ | |||
| FROM registry.ci.openshift.org/origin/4.12:artifacts as artifacts | |||
| FROM registry.ci.openshift.org/origin/4.12:machine-config-operator as mcd | |||
| FROM registry.ci.openshift.org/origin/4.12:rhel-coreos-8 as rhcos | |||
There was a problem hiding this comment.
we can't do this unfortunately if we want any kind of reproducibility out side of builds that have access to ocp - rhel-coreos-8 isn't going to be mirrored to origin going forward.
There was a problem hiding this comment.
Ah, snap, we might want to have src version of os then (present in the imagestream, but not included in the payload)
There was a problem hiding this comment.
that would be nice indeed. I think for now, let's just remove the fcos config, and continue with the os submodule?
There was a problem hiding this comment.
lets wait for openshift/release#31973 to merge and I'll update this PR.
|
@vrutkovs where does |
|
@vrutkovs: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
@vrutkovs: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We no longer rebuild FCOS using cosa, so we no longer need
fedora-coreossubmodule.From
openshift-ossubmodule only gcp-routes is needed - it can be extracted fromopenshift-os(rhel-8-coreosin the payload).