Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: no need to disable repos #446

Merged

Conversation

vrutkovs
Copy link
Member

We no longer run rpm-ostree update <new machine-os> so repos should be enabled as these are required to install additional packages.

Fixes #445

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
@LorbusChris
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 07d1476 and 2 for PR HEAD 15ec45b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ef639ab and 1 for PR HEAD 15ec45b in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2022
We no longer run `rpm-ostree update <new machine-os>` so repos should be
enabled as these are required to install additional packages
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2022

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2022
@vrutkovs
Copy link
Member Author

/override ci/prow/e2e-gcp-upgrade

Known issue

@vrutkovs vrutkovs added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2022

@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-gcp-upgrade

In response to this:

/override ci/prow/e2e-gcp-upgrade

Known issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2022

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit aebad56 into openshift:master Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why are yum repos disabled?
4 participants