Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] control plain upgrade: fix adm typo #8547

Merged
merged 1 commit into from May 29, 2018

Conversation

vrutkovs
Copy link
Member

Additional adm was introduced in #8428

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1583151

/cc @DanyC97

@openshift-ci-robot
Copy link

@vrutkovs: GitHub didn't allow me to request PR reviews from the following users: DanyC97.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Additional adm was introduced in #8428

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1583151

/cc @DanyC97

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 28, 2018
@openshift-ci-robot
Copy link

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp 75edf45 link /test gcp
ci/openshift-jenkins/install 75edf45 link /test install
ci/openshift-jenkins/logging 75edf45 link /test logging

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@DanyC97
Copy link
Contributor

DanyC97 commented May 28, 2018

thanks @vrutkovs ! you beat me ;)

Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtnbikenc, vrutkovs
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson merged commit a60c227 into openshift:release-3.7 May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants