Use route/v1 types for route warnings.

pkg/route/apis/route/validation/validation.go

@@ -388,3 +388,21 @@ func validateWildcardPolicy(host string, policy routev1.WildcardPolicyType, fldP
 
 	return nil
 }
+
+func Warnings(route *routeapi.Route) []string {
+	external, errs := toRouteV1(route)
+	if len(errs) > 0 {
+		return nil
+	}
+
+	return warningsV1(external)
+}
+
+func warningsV1(route *routev1.Route) []string {
+	if len(route.Spec.Host) != 0 && len(route.Spec.Subdomain) != 0 {
+		var warnings []string
+		warnings = append(warnings, "spec.host is set; spec.subdomain may be ignored")
+		return warnings
+	}
+	return nil
+}

pkg/route/apis/route/validation/validation_test.go

@@ -1316,3 +1316,47 @@ func TestValidateEdgeReencryptInsecureEdgeTerminationPolicy(t *testing.T) {
 		}
 	}
 }
+
+func TestWarnings(t *testing.T) {
+	for _, tc := range []struct {
+		name      string
+		host      string
+		subdomain string
+		expected  []string
+	}{
+		{
+			name:      "both host and subdomain set",
+			host:      "foo",
+			subdomain: "bar",
+			expected:  []string{"spec.host is set; spec.subdomain may be ignored"},
+		},
+		{
+			name: "only host set",
+			host: "foo",
+		},
+		{
+			name:      "only subdomain set",
+			subdomain: "bar",
+		},
+		{
+			name: "both host and subdomain unset",
+		},
+	} {
+		t.Run(tc.name, func(t *testing.T) {
+			actual := warningsV1(&routev1.Route{
+				Spec: routev1.RouteSpec{
+					Host:      tc.host,
+					Subdomain: tc.subdomain,
+				},
+			})
+			if len(actual) != len(tc.expected) {
+				t.Fatalf("expected %#v, got %#v", tc.expected, actual)
+			}
+			for i := range actual {
+				if actual[i] != tc.expected[i] {
+					t.Fatalf("expected %#v, got %#v", tc.expected, actual)
+				}
+			}
+		})
+	}
+}

pkg/route/apiserver/registry/route/strategy.go

@@ -75,7 +75,7 @@ func (s routeStrategy) Validate(ctx context.Context, obj runtime.Object) field.E
 
 // WarningsOnCreate returns warnings for the creation of the given object.
 func (routeStrategy) WarningsOnCreate(ctx context.Context, obj runtime.Object) []string {
-	return hostAndSubdomainBothSetWarning(obj)
+	return validation.Warnings(obj.(*routeapi.Route))
 }
 
 func (routeStrategy) AllowCreateOnUpdate() bool {
@@ -96,7 +96,7 @@ func (s routeStrategy) ValidateUpdate(ctx context.Context, obj, old runtime.Obje
 
 // WarningsOnUpdate returns warnings for the given update.
 func (routeStrategy) WarningsOnUpdate(ctx context.Context, obj, old runtime.Object) []string {
-	return hostAndSubdomainBothSetWarning(obj)
+	return validation.Warnings(obj.(*routeapi.Route))
 }
 
 func (routeStrategy) AllowUnconditionalUpdate() bool {
@@ -168,15 +168,3 @@ func DecorateLegacyRouteWithEmptyDestinationCACertificates(obj runtime.Object) e
 		return fmt.Errorf("unknown type passed to %T", obj)
 	}
 }
-
-// hostAndSubdomainBothSetWarning returns a warning if a route has both
-// spec.host and spec.subdomain set.
-func hostAndSubdomainBothSetWarning(obj runtime.Object) []string {
-	newRoute := obj.(*routeapi.Route)
-	if len(newRoute.Spec.Host) != 0 && len(newRoute.Spec.Subdomain) != 0 {
-		var warnings []string
-		warnings = append(warnings, "spec.host is set; spec.subdomain may be ignored")
-		return warnings
-	}
-	return nil
-}