Bug 1867380: When using webhooks in OCP 4.5 fails to rollout latest deploymentconfig #165
Conversation
openshift-ci-robot
added
the
bugzilla/severity-urgent
|
@p0lyn0mial: This pull request references Bugzilla bug 1867380, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/assign @soltysh for approval |
|
@p0lyn0mial: GitHub didn't allow me to assign the following users: for, approval. Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Great find! |
|
/lgtm cc @adambkaplan |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherrypick release-4.6 |
|
@p0lyn0mial: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@p0lyn0mial: All pull requests linked via external trackers have merged: Bugzilla bug 1867380 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@p0lyn0mial: new pull request created: #166 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.5 |
|
@sttts: new pull request created: #168 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
DeploymentConfigkind is registered underv1in the scheme. Registration happens hereopenshift-apiserver/pkg/apps/apis/apps/v1/register.go
Line 15 in e75d326
When calling a webhook we need to specify the version explicitly otherwise the kind won't be found in the registry and the requests will fail with
no kind "DeploymentConfig" is registered for version "apps.openshift.io/" in schemeIt seems this was the only place it was broken. Feel free to double-check that.