Bug 1961557: sets shutdown-delay-duration from OpenShiftAPIServerConfig #199

openshift-cherrypick-robot · 2021-04-07T09:12:31Z

This is an automated cherry-pick of #198

/assign p0lyn0mial

ShutdownDelayDuration allows to block shutdown for some time, e.g. until endpoints pointing to this API server have converged on all node. During this time, the API server keeps serving, /healthz will return 200, but /readyz will return failure. This is important for graceful shutdown.

openshift-ci-robot · 2021-04-07T09:12:50Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sttts · 2021-05-18T08:34:19Z

/override ci/prow/e2e-cmd

openshift-ci · 2021-05-18T08:34:21Z

@sttts: Overrode contexts on behalf of sttts: ci/prow/e2e-cmd

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

p0lyn0mial · 2021-05-18T09:13:12Z

/retitle Bug 1961557: sets shutdown-delay-duration from OpenShiftAPIServerConfig

openshift-ci · 2021-05-18T09:13:31Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1961557, which is invalid:

expected dependent Bugzilla bug 1961554 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sttts · 2021-05-18T10:47:15Z

/lgtm
/approve

openshift-ci · 2021-05-18T10:48:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-05-19T01:01:12Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-19T01:01:16Z

@openshift-bot: This pull request references Bugzilla bug 1961557, which is invalid:

expected dependent Bugzilla bug 1961554 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-20T01:00:44Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-20T01:00:48Z

@openshift-bot: This pull request references Bugzilla bug 1961557, which is invalid:

expected dependent Bugzilla bug 1961554 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-21T01:01:23Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-21T01:01:27Z

@openshift-bot: This pull request references Bugzilla bug 1961557, which is invalid:

expected dependent Bugzilla bug 1961554 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-22T01:00:42Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-22T01:00:45Z

@openshift-bot: This pull request references Bugzilla bug 1961557, which is invalid:

expected dependent Bugzilla bug 1961554 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-23T01:00:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-23T01:00:52Z

@openshift-bot: This pull request references Bugzilla bug 1961557, which is invalid:

expected dependent Bugzilla bug 1961554 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-24T01:00:49Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-24T01:00:53Z

@openshift-bot: This pull request references Bugzilla bug 1961557, which is invalid:

expected dependent Bugzilla bug 1961554 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-25T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-25T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1961557, which is invalid:

expected dependent Bugzilla bug 1961554 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-26T01:00:56Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-26T01:00:59Z

@openshift-bot: This pull request references Bugzilla bug 1961557, which is invalid:

expected dependent Bugzilla bug 1961554 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-27T01:00:37Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-27T01:00:46Z

@openshift-bot: This pull request references Bugzilla bug 1961557, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1961554 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1961554 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-28T02:43:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T04:07:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T04:55:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-05-28T07:50:48Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/openshift-apiserver#199

Bugzilla bug 1961557 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned p0lyn0mial Apr 7, 2021

openshift-cherrypick-robot mentioned this pull request Apr 7, 2021

sets shutdown-delay-duration from OpenShiftAPIServerConfig #198

Merged

openshift-ci-robot requested review from deads2k and sttts April 7, 2021 09:12

openshift-ci bot changed the title ~~[release-4.7] sets shutdown-delay-duration from OpenShiftAPIServerConfig~~ Bug 1961557: sets shutdown-delay-duration from OpenShiftAPIServerConfig May 18, 2021

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 18, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021

openshift-ci bot assigned sttts May 18, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 27, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 27, 2021

openshift-ci bot requested a review from xingxingxia May 27, 2021 01:00

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 27, 2021

openshift-merge-robot merged commit eb2414c into openshift:release-4.7 May 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1961557: sets shutdown-delay-duration from OpenShiftAPIServerConfig #199

Bug 1961557: sets shutdown-delay-duration from OpenShiftAPIServerConfig #199

openshift-cherrypick-robot commented Apr 7, 2021

openshift-ci-robot commented Apr 7, 2021

sttts commented May 18, 2021

openshift-ci bot commented May 18, 2021

p0lyn0mial commented May 18, 2021

openshift-ci bot commented May 18, 2021

sttts commented May 18, 2021

openshift-ci bot commented May 18, 2021

openshift-bot commented May 19, 2021

openshift-ci bot commented May 19, 2021

openshift-bot commented May 20, 2021

openshift-ci bot commented May 20, 2021

openshift-bot commented May 21, 2021

openshift-ci bot commented May 21, 2021

openshift-bot commented May 22, 2021

openshift-ci bot commented May 22, 2021

openshift-bot commented May 23, 2021

openshift-ci bot commented May 23, 2021

openshift-bot commented May 24, 2021

openshift-ci bot commented May 24, 2021

openshift-bot commented May 25, 2021

openshift-ci bot commented May 25, 2021

openshift-bot commented May 26, 2021

openshift-ci bot commented May 26, 2021

openshift-bot commented May 27, 2021

openshift-ci bot commented May 27, 2021

openshift-bot commented May 28, 2021

openshift-bot commented May 28, 2021

openshift-bot commented May 28, 2021

openshift-ci bot commented May 28, 2021

Bug 1961557: sets shutdown-delay-duration from OpenShiftAPIServerConfig #199

Bug 1961557: sets shutdown-delay-duration from OpenShiftAPIServerConfig #199

Conversation

openshift-cherrypick-robot commented Apr 7, 2021

openshift-ci-robot commented Apr 7, 2021

sttts commented May 18, 2021

openshift-ci bot commented May 18, 2021

p0lyn0mial commented May 18, 2021

openshift-ci bot commented May 18, 2021

sttts commented May 18, 2021

openshift-ci bot commented May 18, 2021

openshift-bot commented May 19, 2021

openshift-ci bot commented May 19, 2021

openshift-bot commented May 20, 2021

openshift-ci bot commented May 20, 2021

openshift-bot commented May 21, 2021

openshift-ci bot commented May 21, 2021

openshift-bot commented May 22, 2021

openshift-ci bot commented May 22, 2021

openshift-bot commented May 23, 2021

openshift-ci bot commented May 23, 2021

openshift-bot commented May 24, 2021

openshift-ci bot commented May 24, 2021

openshift-bot commented May 25, 2021

openshift-ci bot commented May 25, 2021

openshift-bot commented May 26, 2021

openshift-ci bot commented May 26, 2021

openshift-bot commented May 27, 2021

openshift-ci bot commented May 27, 2021

openshift-bot commented May 28, 2021

openshift-bot commented May 28, 2021

openshift-bot commented May 28, 2021

openshift-ci bot commented May 28, 2021