Bug 1986562: Stop updating LastTriggeredImageID in spec #239
Conversation
pkg/build/apis/build/types.go
Outdated
| // Deprecated: LastTriggerImageID is deprecated, will not be populated anymore and | ||
| // should not be used |
There was a problem hiding this comment.
Godoc should be updated in openshift/api first, then vendored in.
We have code generators that update the godoc.
LastTriggeredImageID field of BuildConfig Spec is now left empty, and tests are adjusted accordingly.
|
@alicerum @adambkaplan so that ICT test case I've mentioned in scrum a time or two ....in case this is not already in your queue based on the e2e-aws results in this PR (though I did not see a related openshift/origin PR with @alicerum as the author), I believe that the image registry ICT test case that openshift/origin#26098 touches will have to be changed in some fashion similar to what I did in that PR, as it inspects the build.spec.lasttriggeredimageID field. Of course feel free to unhold that PR, use the commit as a basis for a new PR, or totally redo that PR in a different fashion to get the same results. |
|
@gabemontero oh I am currently working on e2e failing tests for BUILD-188, but there is still no PR. I will take a closer look at your PR |
|
/retitle Bug 1986562: Stop updating LastTriggeredImageID in spec |
openshift-ci
bot
changed the title
openshift-ci
bot
added
bugzilla/severity-low
|
@alicerum: This pull request references Bugzilla bug 1986562, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest |
openshift-ci
bot
added
the
approved
|
@alicerum: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
the requisite tests in e2e-aws and e2e-aws-builds passed an unrelated sig-arch flake in e2e-cmd /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, alicerum, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alicerum: All pull requests linked via external trackers have merged: Bugzilla bug 1986562 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LastTriggeredImageID field of BuildConfig Spec is marked as deprecated
and should not be set or used anymore.