Drop AllocateRouterShard from hostname allocation interface. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/test verify |
3 similar comments
|
/test verify |
|
/test verify |
|
/test verify |
Route host allocation requires two function calls, AllocateRouterShard(route) followed by GenerateHostname(route, shard). The shard allocation step is effectively a no-op, so remove it to simplify the process of replacing this with an internal-to-v1 shim.
benluddy
force-pushed
the
drop-route-allocateshard
branch
from
79046cd
to
c0f9b39
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@benluddy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route host allocation requires two function calls, AllocateRouterShard(route) followed by GenerateHostname(route, shard). The shard allocation step is effectively a no-op, so remove it to simplify the process of replacing this with an internal-to-v1 shim.