Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade distribution to v3 #378

Merged
merged 5 commits into from Jul 12, 2023
Merged

Upgrade distribution to v3 #378

merged 5 commits into from Jul 12, 2023

Conversation

flavianmissi
Copy link
Member

In https://issues.redhat.com/browse/IR-371 we had to upgrade the registry (and library-go) to use distribution v3. To be on the safe side, we're upgrading distribution to v3 everywhere where is relevant.

@openshift-ci openshift-ci bot requested review from benluddy and mfojtik June 16, 2023 11:46
@flavianmissi
Copy link
Member Author

/retest

@flavianmissi
Copy link
Member Author

e2e-aws-ovn failure is caused to the deprecation warning for DeploymentConfigs. Reported it: OCPBUGS-15291

@flavianmissi
Copy link
Member Author

/test e2e-aws-ovn-serial

@miheer miheer mentioned this pull request Jul 1, 2023
Closed
@flavianmissi
Copy link
Member Author

/test e2e-aws-ovn

dinhxuanvu
dinhxuanvu reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dinhxuanvu
Copy link
Member

@p0lyn0mial PTAL for approval

@dinhxuanvu
Copy link
Member

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@p0lyn0mial
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, flavianmissi, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 115e0f9 and 2 for PR HEAD cac11ec in total

@ardaguclu
Copy link
Member

/retest

@ardaguclu
Copy link
Member

unrelated failure;
/retest-required

@ardaguclu
Copy link
Member

/retest

@ingvagabund
Copy link
Member

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e321623 into openshift:master Jul 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu left review comments

@benluddy benluddy Awaiting requested review from benluddy

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@flavianmissi @dinhxuanvu @p0lyn0mial @openshift-ci-robot @ardaguclu @ingvagabund @openshift-merge-robot