Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-31509: vendor upgrade runtime-utils #426

Merged
merged 1 commit into from
May 2, 2024
Merged

[release-4.14] OCPBUGS-31509: vendor upgrade runtime-utils #426

merged 1 commit into from
May 2, 2024

Conversation

QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Apr 16, 2024 •
edited

4.14 backport #422
runtime-utils release-4.14 updated in openshift/runtime-utils#21

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 16, 2024
@openshift-ci-robot
Copy link

@QiWang19: This pull request references Jira Issue OCPBUGS-31509, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

runtime-utils release-4.14 updated in openshift/runtime-utils#21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 16, 2024
@openshift-ci-robot
Copy link

@QiWang19: This pull request references Jira Issue OCPBUGS-31509, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-31469 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-31469 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wewang+old@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 16, 2024
@QiWang19
Copy link
Member Author

@flavianmissi PTAL

@flavianmissi
Copy link
Member

Hi @QiWang19, looks like runtime-utils didn't change in the go.mod - maybe something went wrong during your update?
https://github.com/openshift/openshift-apiserver/pull/426/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R26

@QiWang19
[release-4.14] OCPBUGS-31509: vendor upgrade runtime-utils
6a99e20 
Signed-off-by: Qi Wang <qiwan@redhat.com>
@QiWang19
Copy link
Member Author

😳 yes... there was something wrong
rebased

@flavianmissi
Copy link
Member

looks right now!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@xiuwang
Copy link

xiuwang commented Apr 18, 2024

/retest

@xiuwang
Copy link

xiuwang commented Apr 18, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 18, 2024
@openshift-ci-robot
Copy link

@QiWang19: This pull request references Jira Issue OCPBUGS-31509, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-31469 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-31469 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

backport #422
runtime-utils release-4.14 updated in openshift/runtime-utils#21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xiuwang April 18, 2024 09:50
@xiuwang
Copy link

xiuwang commented Apr 19, 2024

/remove-label qe-approved

@openshift-ci openshift-ci bot removed the qe-approved Signifies that QE has signed off on this PR label Apr 19, 2024
@xiuwang
Copy link

xiuwang commented Apr 19, 2024

/label qe-approved

Add it back, since I validate it again, the itms and idms work as expected

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 19, 2024
@xiuwang
Copy link

xiuwang commented Apr 22, 2024

/retest

1 similar comment
@xiuwang
Copy link

xiuwang commented Apr 29, 2024

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

@QiWang19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-cmd 6a99e20 link false /test e2e-aws-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@QiWang19: This pull request references Jira Issue OCPBUGS-31509, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-31469 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-31469 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

4.14 backport #422
runtime-utils release-4.14 updated in openshift/runtime-utils#21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

@sanchezl could you help with the approved and backport label?

sanchezl
sanchezl approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 1, 2024

@sanchezl: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, QiWang19, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2024
@mrunalp mrunalp added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 1, 2024
@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f41d636 into openshift:release-4.14 May 2, 2024
8 of 9 checks passed
@openshift-ci-robot
Copy link

@QiWang19: Jira Issue OCPBUGS-31509: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31509 has been moved to the MODIFIED state.

In response to this:

4.14 backport #422
runtime-utils release-4.14 updated in openshift/runtime-utils#21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-openshift-apiserver-container-v4.14.0-202405020437.p0.gf41d636.assembly.stream.el8 for distgit ose-openshift-apiserver.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-05-02-211455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchezl sanchezl sanchezl approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@xiuwang xiuwang Awaiting requested review from xiuwang

Assignees

@flavianmissi flavianmissi

@xingxingxia xingxingxia

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet