Update to kubernetes-1.17.0 #63
Conversation
openshift-ci-robot
added
size/XXL
| github.com/openshift/apiserver-library-go v0.0.0-20191121105954-72a8df0fc9cc | ||
| github.com/openshift/client-go v0.0.0-20190923180330-3b6373338c9b | ||
| github.com/openshift/library-go v0.0.0-20190924092619-a8c1174d4ee7 | ||
| github.com/openshift/api v3.9.1-0.20190923175213-ecbc01928def+incompatible |
There was a problem hiding this comment.
@deads2k because go.mod is incredibly stupid, it picks the only existing tag in this repo (and wrong commit...) i think we need to remove that tag or start using tags properly in that repo...
For now, I need to use replace to pin it into HEAD of master branch.
| @@ -39,7 +39,8 @@ var MissingValidationExceptions = []reflect.Type{ | |||
|
|
|||
| func TestCoverage(t *testing.T) { | |||
| for kind, apiType := range legacyscheme.Scheme.KnownTypes(legacy.InternalGroupVersion) { | |||
| if strings.HasPrefix(apiType.PkgPath(), "github.com/openshift/openshift-apiserver/vendor/") { | |||
| if strings.HasPrefix(apiType.PkgPath(), "k8s.io/kubernetes/pkg/apis") || | |||
There was a problem hiding this comment.
@bparees or @adambkaplan I think you asked on slack the other day
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
| k8s.io/sample-cli-plugin => k8s.io/sample-cli-plugin v0.0.0-20191118183100-3aef6409ab31 | ||
| k8s.io/sample-controller => k8s.io/sample-controller v0.0.0-20191118182133-e0ba6ec94108 | ||
| k8s.io/api => k8s.io/api v0.17.0 | ||
| k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.17.0 |
There was a problem hiding this comment.
weird that these are pinned, but this is a leaf for now. We'll come back to fix.
| @@ -7,7 +7,7 @@ CODEGEN_PKG=${CODEGEN_PKG:-$(cd ${SCRIPT_ROOT}; ls -d -1 ./vendor/k8s.io/code-ge | |||
|
|
|||
| verify="${VERIFY:-}" | |||
|
|
|||
| go install ./${CODEGEN_PKG}/cmd/deepcopy-gen | |||
| GOFLAGS="" go install ./${CODEGEN_PKG}/cmd/deepcopy-gen | |||
There was a problem hiding this comment.
? doesn't this need to be vendor mode?
There was a problem hiding this comment.
Not here, because how these tools are build. I was inclined to move towards binaries that we'll wget like we did with controller-gen
|
/override ci/prow/e2e-aws e2e-aws flake hard on: openshift/origin#24320 (has BZ linked) Both PR's are approved and waiting for merge, no need to wait for merging them here. |
|
@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws, ci/prow/e2e-cmd In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mfojtik: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.