Use IPv6 in resolver cache tests #65
Conversation
openshift-ci-robot
added
size/XS
|
/assign @dmage |
| @@ -57,13 +57,13 @@ func TestServiceResolverCache(t *testing.T) { | |||
| c = fakeRetriever{ | |||
| service: &corev1.Service{ | |||
| Spec: corev1.ServiceSpec{ | |||
| ClusterIP: "127.0.0.1", | |||
| ClusterIP: "::1/128", | |||
There was a problem hiding this comment.
@adambkaplan why do you need /128 here? I wouldn't expect to see CIDR here.
There was a problem hiding this comment.
@dmage you're right, should just be ::1. Make me wonder how this is passing (perhaps the /128 is ignored?)
There was a problem hiding this comment.
@dmage fixed - looks like the function under test just accepts the string as-is, doesn't do any verification
Use "::1/128" instead of 127.0.0.1
adambkaplan
force-pushed
the
ipv6-resolvercache
branch
from
f4f956d
to
2c1ab31
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, dmage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use "::1/128" instead of 127.0.0.1