Bug 1795705: return actual instantiate error for binary builds #71
Conversation
|
@gabemontero: This pull request references Bugzilla bug 1795705, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@gabemontero: This pull request references Bugzilla bug 1795705, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| if err != nil { | ||
| if errors.IsNotFound(err) { | ||
| if s, ok := err.(errors.APIStatus); ok { | ||
| result, instErr := h.r.Generator.InstantiateInternal(h.ctx, request) |
There was a problem hiding this comment.
I think this is going to create a shadow instErr:
https://play.golang.org/p/HoAVzyXmzrv
There was a problem hiding this comment.
good catch !!
update in a moment
There was a problem hiding this comment.
update pushed @bparees
gabemontero
force-pushed
the
more-bin-bld-debuggability
branch
from
43946d6
to
78cd4be
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@gabemontero: All pull requests linked via external trackers have merged. Bugzilla bug 1795705 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
per discussions today with @bparees and @ricardomaraschini
@openshift/openshift-team-developer-experience FYI
/assign @bparees