Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release 4.5] Bug 1811801: /readyz should start returning failure on shutdown initiation #80

Merged
merged 2 commits into from Mar 10, 2020
Merged

[release 4.5] Bug 1811801: /readyz should start returning failure on shutdown initiation #80

merged 2 commits into from Mar 10, 2020

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Mar 9, 2020 •
edited

UPSTREAM 88911: /readyz should start returning failure on shutdown initiation

@tkashem
ensure vendor folder is in sync
d4c99e5 
run `go mod vendor` and `go mod tidy` and save changes to go.sum
@tkashem
revendor openshift/kubernetes-apiserver
e2341e6 
revendor the latest of openshift-apiserver-4.4-kubernetes-1.17.3
branch of openshift/kubernetes-apiserver.

This will bring in the following change:
- UPSTREAM 88911: /readyz should start returning failure on shutdown initiation
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 9, 2020
@tkashem
Copy link
Contributor Author

tkashem commented Mar 9, 2020

/retest

@sttts sttts changed the title revendor openshift/kubernetes-apiserver [release 4.5] Bug 1811202: /readyz should start returning failure on shutdown initiation Mar 10, 2020
@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1811202, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release 4.5] Bug 1811202: /readyz should start returning failure on shutdown initiation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 10, 2020
@sttts
Copy link
Contributor

sttts commented Mar 10, 2020

/retest

@sttts
Copy link
Contributor

sttts commented Mar 10, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@sttts sttts changed the title [release 4.5] Bug 1811202: /readyz should start returning failure on shutdown initiation [release 4.5] Bug 1811801: /readyz should start returning failure on shutdown initiation Mar 10, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 10, 2020
@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1811801, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

[release 4.5] Bug 1811801: /readyz should start returning failure on shutdown initiation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 10, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fe2caea into openshift:master Mar 10, 2020
@openshift-ci-robot
Copy link

@tkashem: All pull requests linked via external trackers have merged. Bugzilla bug 1811801 has been moved to the MODIFIED state.

In response to this:

[release 4.5] Bug 1811801: /readyz should start returning failure on shutdown initiation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tkashem @openshift-ci-robot @sttts @openshift-bot @openshift-merge-robot