New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove system:registry cluster role #88
Remove system:registry cluster role #88
Conversation
/assign @sttts |
/retest |
/assign @mfojtik |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
The system:registry cluster role in 4.x is managed by cluster-image-registry-operator
https://github.com/openshift/cluster-image-registry-operator/blob/a925d0e2ac596b393a29b808a51607a36db15f4d/pkg/resource/clusterrole.go#L44
This PR is to avoid problems when the same object is managed by two controllers.