arm is not ready even config is persisted. removes race conditions

cmd/monitoring/monitoring.go

@@ -73,6 +73,7 @@ func (m *monitor) init(ctx context.Context, log *logrus.Entry) error {
 func (m *monitor) listResourceGroupMonitoringHostnames(ctx context.Context, subscriptionID, resourceGroup string) (hostnames []string, err error) {
 	// get dedicated routes we want to monitor
 	m.log.Debug("waiting for OpenShiftManagedCluster config to be persisted")
+	hostnames = []string{}
 	for {
 		oc, err := loadOCConfig()
 		if err != nil {
@@ -84,10 +85,9 @@ func (m *monitor) listResourceGroupMonitoringHostnames(ctx context.Context, subs
 	}
 	// get all external IP's used by VMSS
 	m.log.Debug("waiting for ss-masters ip addresses")
-	hostnames = []string{}
 	for iter, err := m.pipcli.ListVirtualMachineScaleSetPublicIPAddressesComplete(ctx, resourceGroup, "ss-master"); iter.NotDone(); err = iter.Next() {
 		if err != nil {
-			return nil, err
+			time.Sleep(5 * time.Second)
 		} else if iter.Value().IPAddress != nil {
 			hostnames = append(hostnames, *iter.Value().IPAddress)
 		}
@@ -96,7 +96,7 @@ func (m *monitor) listResourceGroupMonitoringHostnames(ctx context.Context, subs
 	m.log.Debug("waiting for ip-apiserver server hostname")
 	ip, err := m.pipcli.Get(ctx, resourceGroup, "ip-apiserver", "")
 	if err != nil {
-		return nil, err
+		time.Sleep(5 * time.Second)
 	} else if err == nil && ip.Location != nil {
 		hostnames = append(hostnames, fmt.Sprintf("%s.%s.cloudapp.azure.com", *ip.DNSSettings.DomainNameLabel, *ip.Location))
 	}