Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert logging validation #1519

Merged
merged 1 commit into from Apr 16, 2019
Merged

Conversation

mjudeikis
Copy link
Contributor

NONE

fix: #1293
Revert of logging lock/validation

@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2019
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #1519 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1519   +/-   ##
=======================================
  Coverage   43.22%   43.22%           
=======================================
  Files         194      194           
  Lines       13854    13854           
=======================================
  Hits         5988     5988           
  Misses       7511     7511           
  Partials      355      355

@mjudeikis
Copy link
Contributor Author

flake: #1424

@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis
Copy link
Contributor Author

flake: #1448
/retest

@ehashman
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jim-minter jim-minter merged commit 8e5f4e3 into openshift:master Apr 16, 2019
@mjudeikis mjudeikis deleted the revert.logging branch April 26, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log level 8 - breaks cluster creation
4 participants