New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query VMImage version #2207
Query VMImage version #2207
Conversation
gburges
commented
Jan 31, 2020
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gburges The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2207 +/- ##
==========================================
+ Coverage 40.37% 42.04% +1.66%
==========================================
Files 291 305 +14
Lines 21274 23288 +2014
==========================================
+ Hits 8590 9792 +1202
- Misses 12182 12921 +739
- Partials 502 575 +73 |
/rerun #2168 flake |
/retest |
1 similar comment
/retest |
I think this is no longer WIP now that tests are passing? |
right, thanks for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with Angus, the naming is very confusing. I can't tell the difference between these two Geneva actions.
I think we should hold this as I don't think MS wants to roll out any additional Geneva actions right now for 3.11. Let's keep this on the back burner.
/hold
@gburges: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/close out of scope for now |
@ehashman: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |