Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query VMImage version #2207

Closed
wants to merge 1 commit into from
Closed

Query VMImage version #2207

wants to merge 1 commit into from

Conversation

gburges
Copy link
Contributor

@gburges gburges commented Jan 31, 2020

NONE

@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gburges
To complete the pull request process, please assign mjudeikis
You can assign the PR to them by writing /assign @mjudeikis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2020
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #2207 into master will increase coverage by 1.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2207      +/-   ##
==========================================
+ Coverage   40.37%   42.04%   +1.66%     
==========================================
  Files         291      305      +14     
  Lines       21274    23288    +2014     
==========================================
+ Hits         8590     9792    +1202     
- Misses      12182    12921     +739     
- Partials      502      575      +73

@gburges
Copy link
Contributor Author

gburges commented Feb 7, 2020

/rerun

#2168 flake

@gburges
Copy link
Contributor Author

gburges commented Feb 7, 2020

/retest

1 similar comment
@gburges
Copy link
Contributor Author

gburges commented Feb 10, 2020

/retest

@ehashman ehashman changed the title WIP query VMImage version Query VMImage version Feb 18, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2020
@ehashman
Copy link
Contributor

I think this is no longer WIP now that tests are passing?

@gburges
Copy link
Contributor Author

gburges commented Feb 18, 2020

I think this is no longer WIP now that tests are passing?

right, thanks for that

Copy link
Contributor

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Angus, the naming is very confusing. I can't tell the difference between these two Geneva actions.

I think we should hold this as I don't think MS wants to roll out any additional Geneva actions right now for 3.11. Let's keep this on the back burner.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2020
@openshift-ci-robot
Copy link

@gburges: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
upgrade-v16.0 1221277 link /test upgrade-v16.0

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ehashman
Copy link
Contributor

/close

out of scope for now

@openshift-ci-robot
Copy link

@ehashman: Closed this PR.

In response to this:

/close

out of scope for now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants