do not block owner deletion

openshift · Feb 20, 2020 · 1c3dff5 · 1c3dff5
1 parent fca37b3
commit 1c3dff5
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pkg/serviceaccounts/controllers/create_dockercfg_secrets.go b/pkg/serviceaccounts/controllers/create_dockercfg_secrets.go
@@ -501,7 +501,9 @@ func (e *DockercfgController) createDockerPullSecret(serviceAccount *v1.ServiceA
 		return nil, false, err
 	}
 	dockercfgSecret.Data[v1.DockerConfigKey] = dockercfgContent
+	blockDeletion := false
 	ownerRef := metav1.NewControllerRef(tokenSecret, v1.SchemeGroupVersion.WithKind("Secret"))
+	ownerRef.BlockOwnerDeletion = &blockDeletion
 	dockercfgSecret.SetOwnerReferences([]metav1.OwnerReference{*ownerRef})
 
 	// Save the secret
@@ -565,7 +567,9 @@ func (e *DockercfgController) syncDockercfgOwner(pullSecret *v1.Secret) error {
 		return nil
 	}
 	pullSecret = pullSecret.DeepCopy()
+	blockDeletion := false
 	ownerRef := metav1.NewControllerRef(tokenSecretObj, v1.SchemeGroupVersion.WithKind("Secret"))
+	ownerRef.BlockOwnerDeletion = &blockDeletion
 	pullSecret.SetOwnerReferences([]metav1.OwnerReference{*ownerRef})
 	klog.V(4).Infof("Adding token %s/%s as the owner of pull secret %s/%s", pullSecret.Namespace, tokenName, pullSecret.Namespace, pullSecret.Name)
 	_, err = e.client.CoreV1().Secrets(pullSecret.Namespace).Update(pullSecret)