Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1880357: Bump k8s.io packages #140

Merged
merged 1 commit into from Oct 14, 2020
Merged

Bug 1880357: Bump k8s.io packages #140

merged 1 commit into from Oct 14, 2020

Conversation

coreydaley
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 1, 2020
@openshift-ci-robot
Copy link
Contributor

@coreydaley-redhat: This pull request references Bugzilla bug 1880357, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1880369 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1880369 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

Bug 1880357: Bump k8s.io packages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 1, 2020
@coreydaley
Copy link
Member Author

/assign @adambkaplan

@coreydaley
Copy link
Member Author

/retest

2 similar comments
@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

otaviof
otaviof reviewed Oct 2, 2020
View reviewed changes
go.mod
k8s.io/apiserver v0.18.0
k8s.io/client-go v0.18.0
k8s.io/component-base v0.18.0
k8s.io/api v0.18.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be based on v0.18.9? The latest version on the 0.18 release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think k8s cut 0.18.9 very recently. 0.18.8 is sufficient for this bugfix.

adambkaplan
adambkaplan approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

go.mod
k8s.io/apiserver v0.18.0
k8s.io/client-go v0.18.0
k8s.io/component-base v0.18.0
k8s.io/api v0.18.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think k8s cut 0.18.9 very recently. 0.18.8 is sufficient for this bugfix.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit e29f592 into openshift:release-4.5 Oct 14, 2020
@openshift-ci-robot
Copy link
Contributor

@coreydaley-redhat: All pull requests linked via external trackers have merged:

Bugzilla bug 1880357 has been moved to the MODIFIED state.

In response to this:

Bug 1880357: Bump k8s.io packages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stlaz pushed a commit to stlaz/openshift-controller-manager that referenced this pull request Jul 29, 2021
@openshift-merge-robot
Merge pull request openshift#140 from adambkaplan/ocm-upgrade-progres…
2a1a1d6 
…s-status

Bug 1804434: Report "Progressing=True" during ds rollout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviof otaviof otaviof left review comments

@adambkaplan adambkaplan adambkaplan approved these changes

@bparees bparees Awaiting requested review from bparees

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@coreydaley @openshift-ci-robot @otaviof @adambkaplan @knobunc @openshift-merge-robot