Bug 1891362: Remove the openshift_build_result_total metric #143
Conversation
Unlike other phases, the `Failed` phase state logic is spread across the build container and the build controller. As a result, the `handleBuildCompletion` function can be called more than once when processing failed builds. This results in extraneous increments of the counter metric, making the "failed" metric unreliable. Long term the `Failed` phase state logic should be held solely within the build controller. The build pod should use conditions to report the specific details of why a build failed. Once we can verify builds transition the `Failed` phase reliably under unconstrained conditions, we can restore this metric. This reverts commit e1af3a5, reversing changes made to 5e84dd5.
openshift-ci-robot
added
bugzilla/severity-medium
|
@adambkaplan: This pull request references Bugzilla bug 1891362, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/assign @coreydaley |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, coreydaley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@adambkaplan: All pull requests linked via external trackers have merged: Bugzilla bug 1891362 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bug 1806913: Remove run-level for OCM and operator
Unlike other phases, the
Failedphase state logic is spread acrossthe build container and the build controller. As a result, the
handleBuildCompletionfunction can be called more than once whenprocessing failed builds. This results in extraneous increments of the
counter metric, making the "failed" metric unreliable.
Long term the
Failedphase state logic should be held solely withinthe build controller. The build pod should use conditions to report
the specific details of why a build failed. Once we can verify builds
transition the
Failedphase reliably under unconstrained conditions,we can restore this metric.
This reverts commit e1af3a5, reversing
changes made to 5e84dd5.