Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove use of BUILD_ISOLATION env var (no longer inspected in openshift/builder) #161

Merged
merged 1 commit into from Jan 22, 2021
Merged

remove use of BUILD_ISOLATION env var (no longer inspected in openshift/builder) #161

merged 1 commit into from Jan 22, 2021

Conversation

gabemontero
Copy link
Contributor

manual pick of #160 required

tests won't pass until openshift/builder#207 merges

/assign @bparees

@adambkaplan @jupierce FYI

@openshift-ci-robot
Copy link
Contributor

@gabemontero: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

remove use of BUILD_ISOLATION env var (no longer inspected in openshift/builder)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jupierce jupierce added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 21, 2021
@bparees
Copy link
Contributor

bparees commented Jan 21, 2021

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2021
@adambkaplan
Copy link
Contributor

/hold

Until openshift/builder#207 merges

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2021
adambkaplan
adambkaplan approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adambkaplan,bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 21, 2021
@crawford
Copy link

openshift/builder#207 has merged

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

/hold cancel

@crawford
Copy link

/retest

@gabemontero
Copy link
Contributor Author

/test e2e-aws-builds

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

the tests passed with e2e-aws-builds but the release lease failed:

error: some steps failed:
  * could not run steps: step e2e-aws-builds failed: status 500 Internal Server Error, statusCode 500 releasing us-west-1--14
time="2021-01-21T22:57:53Z" level=info msg="Reporting job state 'failed' with reason 'executing_graph:step_failed:utilizing_lease:releasing_lease'"

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

Problem pulling from CI registry e2e-aws-builds

/test e2e-aws-builds

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fe46107 into openshift:release-4.6 Jan 22, 2021
@gabemontero gabemontero deleted the rm-unused-envs-46 branch January 22, 2021 13:40
@gabemontero gabemontero mentioned this pull request Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@adambkaplan adambkaplan

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gabemontero @openshift-ci-robot @bparees @adambkaplan @crawford @openshift-bot @jupierce @openshift-merge-robot