New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.6] Bug 1900991: unidling: switch away from endpoints to the service #167
[release-4.6] Bug 1900991: unidling: switch away from endpoints to the service #167
Conversation
The router (in 4.7) has moved to using endpointslices. Rather than annotating both endpoints and endpointslices oc/idle will now annotate the service associated with the endpoints. Similarly unidling now needs to remove those idle annotations from the service. - openshift/oc#720 - openshift/router#225
As oc/idle currently annotates endpoints for backwards compatibilty we remove any idle annotations after they have been removed from the service and the scaled resources have been scaled back. If we don't continue with annotating endpoints this commit can be dropped. openshift/oc#720
@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1900989 with correct target release. Retitling PR to link to clone: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1900991, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@frobware: This pull request references Bugzilla bug 1900991, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @soltysh |
=== RUN TestUpdateOldStyleSecretWithKey
I0203 18:13:49.553338 11976 docker_registry_service.go:163] Shutting down DockerRegistryServiceController controller
I0203 18:13:49.559233 11976 docker_registry_service.go:145] Starting DockerRegistryServiceController controller
--- FAIL: TestUpdateOldStyleSecretWithKey (45.01s)
docker_registry_service_test.go:274: Waiting for ready
docker_registry_service_test.go:281: Waiting to reach syncRegistryLocationHandler
docker_registry_service_test.go:287: Waiting to update secret
docker_registry_service_test.go:291: failed to call into syncSecret /retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1900991 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #165
/assign frobware