Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.6] Bug 1900991: unidling: switch away from endpoints to the service #167

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #165

/assign frobware

Andrew McDermott added 2 commits February 3, 2021 18:08
The router (in 4.7) has moved to using endpointslices. Rather than
annotating both endpoints and endpointslices oc/idle will now annotate
the service associated with the endpoints. Similarly unidling now
needs to remove those idle annotations from the service.

- openshift/oc#720
- openshift/router#225
As oc/idle currently annotates endpoints for backwards compatibilty we
remove any idle annotations after they have been removed from the
service and the scaled resources have been scaled back.

If we don't continue with annotating endpoints this commit can be
dropped.

openshift/oc#720
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1900989 with correct target release. Retitling PR to link to clone:
/retitle [release-4.6] Bug 1900991: unidling: switch away from endpoints to the service

In response to this:

[release-4.6] Bug 1900989: unidling: switch away from endpoints to the service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1900989: unidling: switch away from endpoints to the service [release-4.6] Bug 1900991: unidling: switch away from endpoints to the service Feb 3, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 3, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1900991, which is invalid:

  • expected dependent Bugzilla bug 1900989 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1900991: unidling: switch away from endpoints to the service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link

frobware commented Feb 4, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Bugzilla bug 1900991, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1900989 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1900989 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 4, 2021
@frobware
Copy link

frobware commented Feb 4, 2021

/cc @soltysh

@frobware
Copy link

frobware commented Feb 4, 2021

=== RUN   TestUpdateOldStyleSecretWithKey
I0203 18:13:49.553338   11976 docker_registry_service.go:163] Shutting down DockerRegistryServiceController controller
I0203 18:13:49.559233   11976 docker_registry_service.go:145] Starting DockerRegistryServiceController controller
--- FAIL: TestUpdateOldStyleSecretWithKey (45.01s)
    docker_registry_service_test.go:274: Waiting for ready
    docker_registry_service_test.go:281: Waiting to reach syncRegistryLocationHandler
    docker_registry_service_test.go:287: Waiting to update secret
    docker_registry_service_test.go:291: failed to call into syncSecret

/retest

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2021
@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2c81b6f into openshift:release-4.6 Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1900991 has not been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1900991: unidling: switch away from endpoints to the service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants