Bug 2037075: Add Support for Build CSI Volume Sources #214

jkhelil · 2021-12-23T15:03:05Z

https://issues.redhat.com/browse/BUILD-275

jkhelil · 2021-12-23T17:53:32Z

/test e2e-gcp-builds

jkhelil · 2021-12-23T17:53:43Z

/test 2e-aws-upgrade

openshift-ci · 2021-12-23T17:53:45Z

@jkhelil: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws
/test e2e-aws-builds
/test e2e-aws-upgrade
/test e2e-gcp
/test e2e-gcp-builds
/test images
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test e2e-aws-proxy
/test openshift-e2e-aws-builds-techpreview

Use /test all to run all jobs.

In response to this:

/test 2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2022-01-04T15:22:22Z

proxy failure is unrelated to these changes

if I read tide correctly, the OCM repo does not appear to be a no feature freeze repo @jkhelil so you'll need to open a bz and associated it with this PR to get this in, unless @adambkaplan thinks he can change that

otherwise, I'll

/lgtm

and

/assign @adambkaplan

for the approve label

adambkaplan · 2022-01-04T20:47:08Z

/hold

This PR needs openshift/openshift-apiserver#264 to land first.

adambkaplan · 2022-01-04T20:47:39Z

/retitle Bug 2037075: Add Support for Build CSI Volume Sources

openshift-ci · 2022-01-04T20:47:45Z

@jkhelil: This pull request references Bugzilla bug 2037075, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

Bug 2037075: Add Support for Build CSI Volume Sources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan

A suggestion wrt the error message we report if the feature gate is not enabled. Otherwise looks good.

pkg/build/controller/strategy/util.go

jkhelil · 2022-01-06T14:35:03Z

/lgtm

openshift-ci · 2022-01-06T14:35:04Z

@jkhelil: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jkhelil · 2022-01-06T14:35:51Z

/assign @adambkaplan
/cc @gabemontero
Can you approve please ?

adambkaplan

/approve

adambkaplan · 2022-01-06T15:12:08Z

/refresh

adambkaplan · 2022-01-06T15:19:20Z

/close

openshift-ci · 2022-01-06T15:19:52Z

@adambkaplan: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-06T15:19:55Z

@jkhelil: This pull request references Bugzilla bug 2037075. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 2037075: Add Support for Build CSI Volume Sources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2022-01-06T15:20:22Z

/reopen

openshift-ci · 2022-01-06T15:20:53Z

@adambkaplan: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-06T15:20:56Z

@jkhelil: This pull request references Bugzilla bug 2037075, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

Bug 2037075: Add Support for Build CSI Volume Sources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2022-01-06T15:22:20Z

/lgtm

Still keeping the hold until the openshift-apiserver merges.

openshift-ci · 2022-01-06T15:23:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero, jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gabemontero · 2022-01-06T15:36:54Z

apiserver PR merged

/hold cancel

openshift-ci · 2022-01-06T17:38:48Z

@jkhelil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-proxy	`d59a6c4`	link	false	`/test e2e-aws-proxy`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-01-06T17:47:29Z

@jkhelil: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/origin#26646 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2037075 has not been moved to the MODIFIED state.

In response to this:

Bug 2037075: Add Support for Build CSI Volume Sources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-05-01T14:17:41Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-openshift-controller-manager-container-v4.10.0-202305011254.p0.g2c2d50d.assembly.stream for distgit ose-openshift-controller-manager.
All builds following this will include this PR.

openshift-ci bot requested review from gabemontero and soltysh December 23, 2021 15:05

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2021

jkhelil force-pushed the build-275- branch from dc66284 to 8e69cea Compare December 24, 2021 08:44

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 24, 2021

jkhelil force-pushed the build-275- branch from 8e69cea to 48a06e8 Compare December 24, 2021 08:46

openshift-ci bot assigned adambkaplan and gabemontero Jan 4, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2022

openshift-ci bot changed the title ~~BUILD-275: add support for build csi volume source~~ Bug 2037075: Add Support for Build CSI Volume Sources Jan 4, 2022

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 4, 2022

openshift-ci bot requested a review from jitendar-singh January 4, 2022 20:47

adambkaplan reviewed Jan 4, 2022

View reviewed changes

pkg/build/controller/strategy/util.go Outdated Show resolved Hide resolved

jkhelil added 2 commits January 6, 2022 15:05

add support for build csi volume source

81b7ede

bump openshift/api to handle new csi volume type

d59a6c4

jkhelil force-pushed the build-275- branch from 48a06e8 to d59a6c4 Compare January 6, 2022 14:05

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022

adambkaplan approved these changes Jan 6, 2022

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022

openshift-ci bot closed this Jan 6, 2022

openshift-ci bot reopened this Jan 6, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022

openshift-ci bot mentioned this pull request Jan 6, 2022

Bug 2037075: Add CSI VolumeSource to build types openshift/openshift-apiserver#264

Merged

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2022

openshift-merge-robot merged commit 2c2d50d into openshift:master Jan 6, 2022

openshift-ci bot mentioned this pull request Jan 21, 2022

Bug 2037075: Verify Builds with CSI Volume Sources openshift/origin#26646

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2037075: Add Support for Build CSI Volume Sources #214

Bug 2037075: Add Support for Build CSI Volume Sources #214

jkhelil commented Dec 23, 2021 •

edited

jkhelil commented Dec 23, 2021

jkhelil commented Dec 23, 2021

openshift-ci bot commented Dec 23, 2021

gabemontero commented Jan 4, 2022

adambkaplan commented Jan 4, 2022

adambkaplan commented Jan 4, 2022

openshift-ci bot commented Jan 4, 2022

adambkaplan left a comment

jkhelil commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

jkhelil commented Jan 6, 2022

adambkaplan left a comment

adambkaplan commented Jan 6, 2022

adambkaplan commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

adambkaplan commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

adambkaplan commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

gabemontero commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

openshift-bot commented May 1, 2023

Bug 2037075: Add Support for Build CSI Volume Sources #214

Bug 2037075: Add Support for Build CSI Volume Sources #214

Conversation

jkhelil commented Dec 23, 2021 • edited

jkhelil commented Dec 23, 2021

jkhelil commented Dec 23, 2021

openshift-ci bot commented Dec 23, 2021

gabemontero commented Jan 4, 2022

adambkaplan commented Jan 4, 2022

adambkaplan commented Jan 4, 2022

openshift-ci bot commented Jan 4, 2022

adambkaplan left a comment

Choose a reason for hiding this comment

jkhelil commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

jkhelil commented Jan 6, 2022

adambkaplan left a comment

Choose a reason for hiding this comment

adambkaplan commented Jan 6, 2022

adambkaplan commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

adambkaplan commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

adambkaplan commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

gabemontero commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

openshift-ci bot commented Jan 6, 2022

openshift-bot commented May 1, 2023

jkhelil commented Dec 23, 2021 •

edited