Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCPNODE-1258] update runtime-utils for idms migrations #243

Merged
merged 1 commit into from Jun 26, 2023
Merged

[OCPNODE-1258] update runtime-utils for idms migrations #243

merged 1 commit into from Jun 26, 2023

Conversation

QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Oct 3, 2022 •
edited

The epic is planned for 4.14: https://issues.redhat.com/browse/OCPNODE-1258
Update function signature from runtime-utils with idms, itms support. The OCPNODE-521 will land
new CRDs for image mirror configurations for 4.13.
The current components rely on ICSP should use new APIs.

ImageDigestMirrorSet implemented: openshift/machine-config-operator#3037
ImageDigestMirrorSet epic: https://issues.redhat.com/browse/OCPNODE-521

@QiWang19
Copy link
Member Author

QiWang19 commented Oct 3, 2022

/hold
for 4.13 tree to open

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2022
@QiWang19
Copy link
Member Author

QiWang19 commented Nov 3, 2022

/retest

@QiWang19
Copy link
Member Author

QiWang19 commented Nov 4, 2022

/hold cancel
4.13 branch is open. This PR is ready for review.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2022
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2023
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 5, 2023
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Apr 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Member Author

QiWang19 commented Apr 6, 2023

/reopen

@openshift-ci openshift-ci bot reopened this Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

@QiWang19: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Member Author

QiWang19 commented Apr 6, 2023

@gabemontero @mfojtik @sanchezl Could you review?

@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this May 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Member Author

QiWang19 commented May 8, 2023

/reopen

@openshift-ci openshift-ci bot reopened this May 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

@QiWang19: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Member Author

QiWang19 commented May 8, 2023

/retest

@dinhxuanvu
Copy link
Member

The unit test log on CI is not very clear on what happened. Did you see any noticeable when you ran it locally maybe?

@QiWang19
Copy link
Member Author

@dinhxuanvu the unit test failure is nil pointer at this line https://github.com/openshift/openshift-controller-manager/pull/243/files#diff-20f7162567df9fd3d9f64cbb9fdc3129f598b9cd06f83fe8150d663a980706baR251

@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jun 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Member Author

/reopen

@openshift-ci openshift-ci bot reopened this Jun 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023

@QiWang19: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Member Author

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 26, 2023
@QiWang19
[OCPNODE-1258] update runtime-utils for idms migrations
633c4af 
Update runtime-utils with idms, itms support
The OCPNODE-521 landed ImageDigestMirrorSet(IDMS) CRD to 4.13.
This new CRDs for image mirror configurations to replace ICSP in the future release(at least from 4.17).
The current components rely on ICSP should use new APIs.

ImageDigestMirrorSet implemented: openshift/machine-config-operator#3037
ImageDigestMirrorSet epic: https://issues.redhat.com/browse/OCPNODE-521

Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023 •
edited

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openshift-e2e-aws-builds-techpreview b2928f1 link false /test openshift-e2e-aws-builds-techpreview
ci/prow/e2e-aws-upgrade b2928f1 link true /test e2e-aws-upgrade
ci/prow/e2e-gcp b2928f1 link true /test e2e-gcp
ci/prow/e2e-aws-proxy b2928f1 link false /test e2e-aws-proxy
ci/prow/e2e-gcp-builds b2928f1 link true /test e2e-gcp-builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@QiWang19
Copy link
Member Author

/test e2e-aws-ovn

@QiWang19
Copy link
Member Author

@bparees could you review?

@bparees
Copy link
Contributor

bparees commented Jun 26, 2023

/assign @coreydaley

@coreydaley
Copy link
Member

/lgtm

@coreydaley
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2caaf6b into openshift:master Jun 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabemontero gabemontero Awaiting requested review from gabemontero

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@coreydaley coreydaley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@QiWang19 @openshift-bot @dinhxuanvu @bparees @coreydaley @openshift-merge-robot