Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23877: Bumps otelgrpc version & dependencies #293

Conversation

apoorvajagtap
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from bparees and mfojtik March 21, 2024 10:45
@apoorvajagtap apoorvajagtap marked this pull request as draft March 21, 2024 10:50
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2024
@apoorvajagtap apoorvajagtap force-pushed the update-opentelemetry-dependency-master branch from caf2146 to 68c308d Compare March 21, 2024 10:54
@apoorvajagtap apoorvajagtap marked this pull request as ready for review March 21, 2024 10:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2024
@apoorvajagtap
Copy link
Contributor Author

apoorvajagtap commented Mar 21, 2024

/assign @adambkaplan
for review.

@apoorvajagtap
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

@apoorvajagtap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 68c308d link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, apoorvajagtap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
@adambkaplan
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@adambkaplan: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@adambkaplan
Copy link
Contributor

@apoorvajagtap please update the PR title so the JIRA plugin can link to the appropriate issue.

@apoorvajagtap apoorvajagtap changed the title [OCPBUGS-23848] Bumps otelgrpc version & dependencies OCPBUGS-23848: Bumps otelgrpc version & dependencies Mar 23, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 23, 2024
@openshift-ci-robot
Copy link
Contributor

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-23848, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jitendar-singh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit a377f2d into openshift:master Mar 23, 2024
10 of 11 checks passed
@openshift-ci-robot
Copy link
Contributor

@apoorvajagtap: Jira Issue OCPBUGS-23848: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23848 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-openshift-controller-manager-container-v4.16.0-202403240618.p0.ga377f2d.assembly.stream.el9 for distgit ose-openshift-controller-manager.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-03-24-191602

@apoorvajagtap apoorvajagtap changed the title OCPBUGS-23848: Bumps otelgrpc version & dependencies OCPBUGS-23877: Bumps otelgrpc version & dependencies Apr 3, 2024
@openshift-ci-robot
Copy link
Contributor

@apoorvajagtap: Jira Issue OCPBUGS-23877: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-23877 has not been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@apoorvajagtap
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@apoorvajagtap: Jira Issue OCPBUGS-23877: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23877 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants