OCPBUILD-9: Adds roleBinding controllers to the controllerInitializers

[apoorvajagtap]

Related to:

• OCPBUILD-9: Adds seperate controllers for default rolebindings api#1770
• BUILD-725: Adds build & deployer controller #289
• OCPBUILD-9: Adds capabilities for builder & deployer rolebindings controller cluster-openshift-controller-manager-operator#335

[openshift-ci-robot]

@apoorvajagtap: This pull request references OCPBUILD-9 which is a valid jira issue.

In response to this:

Related to:

• OCPBUILD-9: Adds seperate controllers for default rolebindings api#1770
• BUILD-725: Adds build & deployer controller #289

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[apoorvajagtap]

/assign @adambkaplan @sayan-biswas

[openshift-ci-robot]

@apoorvajagtap: This pull request references OCPBUILD-9 which is a valid jira issue.

In response to this:

Related to:

• OCPBUILD-9: Adds seperate controllers for default rolebindings api#1770
• BUILD-725: Adds build & deployer controller #289
• OCPBUILD-9: Adds capabilities for builder & deployer rolebindings controller cluster-openshift-controller-manager-operator#335

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[apoorvajagtap]

/retest-required

[adambkaplan]

/approve

Vendor changes actually look okay. Will look into why the build test failed (we should block merge until this succeeds).

[adambkaplan]

/test e2e-gcp-ovn-builds

[sayan-biswas]

/test openshift-e2e-aws-ovn-builds-techpreview
/test e2e-gcp-ovn-builds

[adambkaplan]

Webhook tests are failing - somebody broke our auth settings. We need system:anonymous permission so SCM providers can send webhooks to our artificial webhook endpoint.

  Apr 25 22:01:55.630: INFO: curl cmd: [-X POST -k https://api.ci-op-tiwx9ltm-6fabf.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX:6443/apis/build.openshift.io/v1/namespaces/e2e-test-cli-start-build-dxxkx/buildconfigs/sample-build/webhooks/mysecret/generic], output: {
    "kind": "Status",
    "apiVersion": "v1",
    "metadata": {},
    "status": "Failure",
    "message": "buildconfigs.build.openshift.io \"sample-build\" is forbidden: User \"system:anonymous\" cannot create resource \"buildconfigs/webhooks\" in API group \"build.openshift.io\" in the namespace \"e2e-test-cli-start-build-dxxkx\"",
    "reason": "Forbidden",
    "details": {
      "name": "sample-build",
      "group": "build.openshift.io",
      "kind": "buildconfigs"
    },
    "code": 403
  }

[adambkaplan]

@apoorvajagtap ditto on this PR - while we are waiting to fix the issues with OCPBUGS-33041, can you please separate this into two commits (update openshift/api in the first one, add "real" code changes in the second one)?

[adambkaplan]

/approve

/lgtm

[adambkaplan]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, apoorvajagtap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@apoorvajagtap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	bf4285a	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-openshift-controller-manager-container-v4.17.0-202405072356.p0.g6d49ea3.assembly.stream.el9 for distgit ose-openshift-controller-manager.
All builds following this will include this PR.