Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ServiceNetworkCIDR Config #58

Merged
merged 1 commit into from Jan 16, 2020
Merged

Remove ServiceNetworkCIDR Config #58

merged 1 commit into from Jan 16, 2020

Conversation

adambkaplan
Copy link
Contributor

Remove defaulting of the ServiceNetworkCIDR configuration.
This has been replaced by the cluster ingress configurations.

@adambkaplan
Remove ServiceNetworkCIDR Config
cbbf637 
Remove defaulting of the ServiceNetworkCIDR configuration.
This has been replaced by the cluster ingress configurations.
@adambkaplan
Copy link
Contributor Author

/assign @ironcladlou

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2019
@adambkaplan
Copy link
Contributor Author

e2e-aws failing on known flakes/failures

/retest

@adambkaplan
Copy link
Contributor Author

bump @ironcladlou - I believe this is deprecated config and can be safely removed.

@ironcladlou
Copy link
Contributor

AFAICT nothing in ingress or DNS needs this, so lgtm — not sure who else might want to review

@ironcladlou
Copy link
Contributor

/lgtm

cc @openshift/sig-networking

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danwinship
Copy link
Contributor

that's not even the right default value anyway so yes, presumably nothing was using this

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8417a9a into openshift:master Jan 16, 2020
stlaz pushed a commit to stlaz/openshift-controller-manager that referenced this pull request Jul 29, 2021
@openshift-merge-robot
Merge pull request openshift#58 from juanvallejo/jvallejo/export-metr…
4fef001 
…ics-container-port

explicitly list metrics port as first containerPort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabemontero gabemontero Awaiting requested review from gabemontero

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@ironcladlou ironcladlou

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adambkaplan @ironcladlou @openshift-ci-robot @danwinship @openshift-bot @openshift-merge-robot