Bug 1801415: Migrate extensions/v1beta1 -> networking.k8s.io/v1beta1 #83
Conversation
|
@ironcladlou: This pull request references Bugzilla bug 1801415, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
ironcladlou
force-pushed
the
migrate-network-pkg
branch
from
e350299
to
897415e
Compare
|
Do we need to convert objects using the old API, as kubernetes/ingress-nginx@84102ee#diff-ece58b3bebec02a6d3173c8d8099d298R904-R939 does? |
|
cc @deads2k @sttts @mfojtik can you help us understand what else we might need to do here (#83 (comment))? |
| @@ -514,7 +514,7 @@ func newRouteForIngress( | |||
| Labels: ingress.Labels, | |||
| Annotations: ingress.Annotations, | |||
| OwnerReferences: []metav1.OwnerReference{ | |||
| {APIVersion: "extensions/v1beta1", Kind: "Ingress", Controller: &t, Name: ingress.Name, UID: ingress.UID}, | |||
| {APIVersion: "networking.k8s.io/v1beta1", Kind: "Ingress", Controller: &t, Name: ingress.Name, UID: ingress.UID}, | |||
There was a problem hiding this comment.
what about existing objects with this owner ref?
There was a problem hiding this comment.
what about existing objects with this owner ref?
They will still be fine until the old API is gone entirely, so you just have to scan for and update them.
In repos that you own, yes you do. |
I'm not sure I asked my question very clearly. When the extensions API group finally "goes away", what exactly happens to the existing persisted resources in etcd? Must this controller (or some operator) be actively migrating the extensions API resources to the new API group to ensure that when the old API is gone forever there's nothing persisted in etcd with the old group? |
|
@deads2k @sttts thoughts on #83 (comment)? |
Nothing to do for operators or other consumers about the persisted api version. The persisted objects will be migrated through kube-storage-version-migrator (which we have an operator for now due to etcd encryption). This must be done before kube-apiserver stops being able to read the old api group. I trust @soltysh to remind us when this must be done. |
|
Looks like this is ready to go then as far as I can tell. cc @openshift/sig-network-edge |
|
/lgtm |
pkg/route/ingress/ingress.go
Outdated
| @@ -8,8 +8,8 @@ import ( | |||
|
|
|||
| "k8s.io/klog" | |||
|
|
|||
| "k8s.io/api/core/v1" | |||
| extensionsv1beta1 "k8s.io/api/extensions/v1beta1" | |||
| v1 "k8s.io/api/core/v1" | |||
ironcladlou
force-pushed
the
migrate-network-pkg
branch
from
897415e
to
b1c9c56
Compare
|
/lgtm |
|
CI flake? /retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, ironcladlou, Miciah, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@ironcladlou: All pull requests linked via external trackers have merged: openshift/openshift-controller-manager#83. Bugzilla bug 1801415 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=1801415