Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1829863: update Dockerfile.rhel builder image to line up with art/brew/osbs #98

Merged
merged 1 commit into from May 1, 2020
Merged

Bug 1829863: update Dockerfile.rhel builder image to line up with art/brew/osbs #98

merged 1 commit into from May 1, 2020

Conversation

gabemontero
Copy link
Contributor

@gabemontero gabemontero commented Apr 29, 2020 •
edited

Outcome of working session at https://coreos.slack.com/archives/CB95J6R4N/p1588170349277200 being able to use the golang 1.3 builder image used by brew/osbs

Worked with @jupierce and @sosiouxme to line it up to install gpgme-devel libassuan-devel in that image

/hold

@adambkaplan @bparees FYI

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2020
@gabemontero
Copy link
Contributor Author

So some mirror pain trying to install those RPMs but it got through to one and figured out the golang 1.13 image being used in CI already has those packages:

STEP 5: RUN yum install -y gpgme-devel libassuan-devel
Loaded plugins: fastestmirror, ovl
Determining fastest mirrors
 * base: d36uatko69830t.cloudfront.net
 * epel: d2lzkl7pfhq30w.cloudfront.net
 * extras: d36uatko69830t.cloudfront.net
 * updates: d36uatko69830t.cloudfront.net
http://csc.mcs.sdsmt.edu/epel/7/x86_64/repodata/e3a9b8be04f41ce4d1921daf8109723d52ab235fc0fe41e1e91660689b724c7f-updateinfo.xml.bz2: [Errno 12] Timeout on http://csc.mcs.sdsmt.edu/epel/7/x86_64/repodata/e3a9b8be04f41ce4d1921daf8109723d52ab235fc0fe41e1e91660689b724c7f-updateinfo.xml.bz2: (28, 'Operation too slow. Less than 1000 bytes/sec transferred the last 30 seconds')
Trying other mirror.
Package gpgme-devel-1.3.2-5.el7.x86_64 already installed and latest version
Package libassuan-devel-2.1.0-3.el7.x86_64 already installed and latest version
Nothing to do

Will hit it a few more times

/test images

@gabemontero
Copy link
Contributor Author

same CI build results as last time.

however, both @jupierce and @sosiouxme are making progress on the CI / brew side of things so the same golang 1.13 image is used in both envs and has gpgme-devel libassuan-devel installed

sitting tight for now but hope to close this PR soon

@gabemontero
Copy link
Contributor Author

ok I'll be pushing a change to the Dockerfile.rhel builder image once openshift/release#8656 merges

I'll leave in the yum install change at least initially to help with sorting out getting those RPMs installed in the new builder (yum will tell us if the rpms are already there)

@jupierce ^^

@gabemontero gabemontero changed the title workaround if we cannot get gpgme-devel into the rhel golang 1.13 ima… update Dockerfile.rhel builder image to line up with art/brew/osbs Apr 29, 2020
@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2020
@gabemontero
Copy link
Contributor Author

/retest

@gabemontero gabemontero changed the title update Dockerfile.rhel builder image to line up with art/brew/osbs Bug 1829863: update Dockerfile.rhel builder image to line up with art/brew/osbs Apr 30, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 30, 2020
@openshift-ci-robot
Copy link
Contributor

@gabemontero: This pull request references Bugzilla bug 1829863, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1829863: update Dockerfile.rhel builder image to line up with art/brew/osbs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 30, 2020
@gabemontero
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 30, 2020
@openshift-ci-robot
Copy link
Contributor

@gabemontero: This pull request references Bugzilla bug 1829863, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor Author

/assign @adambkaplan

the fact that it compiles via https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_openshift-controller-manager/98/pull-ci-openshift-openshift-controller-manager-master-images/198 is the essential validation, and it does so after the efforts from @jupierce @sosiouxme and myself yesterday.

@gabemontero
Copy link
Contributor Author

relevant excerpts from the build log https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_openshift-controller-manager/98/pull-ci-openshift-openshift-controller-manager-master-images/198/artifacts/build-logs/openshift-controller-manager.log

Pulling image registry.svc.ci.openshift.org/ocp/builder:rhel-7-golang-1.13 ...
Getting image source signatures
Copying blob sha256:6941285c092b09f12325b9a1451c74e5bfc19b2715b4f9ff442b08140dfc9872
Copying blob sha256:23302e52b49d49a0a25da8ea870bc1973e7d51c9b306f3539cd397318bd8b0a5
Copying blob sha256:cf5693de4d3cdd6f352978b87c8f89ead294eff44938598f57a91cf7a02417d2
Copying blob sha256:0bdf979777916584a9b874502354ee8d4fed33d269f3f2ce1e6f314a28fa17f4
Copying config sha256:880b6c5c9027e1bdcbd2ad41dcf202a823b43083ea7eec7dece6d0e98179ec7a
Writing manifest to image destination
Storing signatures
STEP 1: FROM registry.svc.ci.openshift.org/ocp/builder:rhel-7-golang-1.13 AS builder
Getting image source signatures
Copying blob sha256:23302e52b49d49a0a25da8ea870bc1973e7d51c9b306f3539cd397318bd8b0a5
Copying blob sha256:6941285c092b09f12325b9a1451c74e5bfc19b2715b4f9ff442b08140dfc9872
Copying blob sha256:cf5693de4d3cdd6f352978b87c8f89ead294eff44938598f57a91cf7a02417d2
Copying blob sha256:0bdf979777916584a9b874502354ee8d4fed33d269f3f2ce1e6f314a28fa17f4
Copying config sha256:880b6c5c9027e1bdcbd2ad41dcf202a823b43083ea7eec7dece6d0e98179ec7a
Writing manifest to image destination
Storing signatures
STEP 2: ENV "foo"="bar"
STEP 3: WORKDIR /go/src/github.com/openshift/openshift-controller-manager
STEP 4: COPY . .
STEP 5: RUN make build --warn-undefined-variables
Makefile:16: warning: undefined variable `4'
go build -trimpath -ldflags "-s -w -X github.com/openshift/openshift-controller-manager/pkg/version.versionFromGit="554623c" -X github.com/openshift/openshift-controller-manager/pkg/version.commitFromGit="554623c765661f1b4b1a488441424307c5759df9" -X github.com/openshift/openshift-controller-manager/pkg/version.gitTreeState="clean" -X github.com/openshift/openshift-controller-manager/pkg/version.buildDate="2020-04-29T22:30:06Z" " github.com/openshift/openshift-controller-manager/cmd/openshift-controller-manager
STEP 6: FROM image-registry.openshift-image-registry.svc:5000/ci-op-ims3k9q5/pipeline@sha256:3823c45b9feec9e861d1fd7ef268e38717b3b94adae26dd76eba3ac5f8b8cab9

@gabemontero
Copy link
Contributor Author

have all green tests @adambkaplan for switching to the rhel7 version golang 1.13 builder

adambkaplan
adambkaplan approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

fyi @mfojtik

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 868eb92 into openshift:master May 1, 2020
@openshift-ci-robot
Copy link
Contributor

@gabemontero: All pull requests linked via external trackers have merged: openshift/openshift-controller-manager#98. Bugzilla bug 1829863 has been moved to the MODIFIED state.

In response to this:

Bug 1829863: update Dockerfile.rhel builder image to line up with art/brew/osbs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the fix-brew-build-pain branch May 7, 2020 22:00
stlaz pushed a commit to stlaz/openshift-controller-manager that referenced this pull request Jul 29, 2021
@openshift-merge-robot
Merge pull request openshift#98 from sanchezl/fallback_to_logs_on_error
9fedae8 
set terminationMessagePolicy to FallbackToLogsOnError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gabemontero @openshift-ci-robot @openshift-bot @adambkaplan @tnozicka @openshift-merge-robot