-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spell Checker to OpenShift docs #28333
Comments
@vikram-redhat Any thoughts? |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
@brian-avery, that's interesting, and I've finally had time to investigate this. We use around 2,000 lowercased words that aren't in the LibreOffice English (US) dictionary. This probably requires additional study. |
Thanks @jboxman. To clarify, some of the spelling errors I caught can be found here: https://github.com/openshift/openshift-docs/pull/28346/files. It's been a bit since I've run the tooling, but some examples from that PR:
|
@brian-avery, cool, @bergerhoffer recently went through and remove all the the doubles and similar. |
Thanks. So we should be good at the moment. I cleaned up all the ones that were there in January. Would it be good to have tooling to detect these issues before they are merged? |
@brian-avery, not sure how viable this is pre-merge. (For example, it's not unheard of that someone touches dozens of files; a pre-commit hook or Travis build could run for quite a while, even if limited to changed files only.) In any case, I'm developing OCP docs specific tooling for this: https://github.com/jboxman/adoc-after I'm experimenting with automated YAML validation as well. |
Awesome. Thanks! In that case, this issue can probably be closed. Curious to see how this turns out. Especially the automated YAML validation. |
Which section(s) is the issue in?
General issue
What needs fixing?
Currently, it's pretty easy for spelling errors and broken links to get merged in the OpenShift documentation. When I ran a spell checker against it, I found several spelling errors. It may be useful to add a spell checker for the OpenShift docs.
If it helps, we use Vale for Maistra.io, which could also be useful in enforcing the OpenShift docs standard as well (there's already an effort by Red Hatters to add implement our standards for the tool). This vocab file currently validates against everything except for misspelled content in the OpenShift Service Mesh docs: https://github.com/maistra/maistra.github.io/blob/maistra-2.0/vocab.txt.
The text was updated successfully, but these errors were encountered: