Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-notes: dhclient is deprecated #32321

Merged
merged 1 commit into from May 11, 2021

Conversation

miabbott
Copy link
Member

@miabbott miabbott commented May 7, 2021

The use of dhclient is deprecated in RHCOS; it is planned to be
removed as part of OCP 4.9

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 7, 2021
@miabbott
Copy link
Member Author

miabbott commented May 7, 2021

cc: @dustymabe @control-d @bobfuru

@netlify
Copy link

netlify bot commented May 7, 2021

Deploy preview for osdocs ready!

Built with commit 38cd86b

https://deploy-preview-32321--osdocs.netlify.app

@bobfuru bobfuru self-requested a review May 7, 2021 18:14
Copy link
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small nits and otherwise this LGTM. Thank you for submitting, Micah!

release_notes/ocp-4-8-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-8-release-notes.adoc Outdated Show resolved Hide resolved
@bobfuru bobfuru added branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR labels May 7, 2021
@bobfuru bobfuru added this to the Future Release milestone May 7, 2021
@bobfuru
Copy link
Contributor

bobfuru commented May 10, 2021

LGTM! Let me know if this is ready for merge, @miabbott.

The use of `dhclient` is deprecated in RHCOS; it is planned to be
removed as part of OCP 4.9

Co-authored-by: Dusty Mabe <dusty@dustymabe.com>
@miabbott
Copy link
Member Author

Squashed Dusty's suggestion into a new commit ⬆️

Should be ready to merge

@bobfuru bobfuru merged commit a8e994c into openshift:enterprise-4.8 May 11, 2021
@bobfuru
Copy link
Contributor

bobfuru commented May 11, 2021

Thank you, @miabbott!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants