Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<install> Changes for activemq-5.9.0 update - enterprise 2.0 #295

Merged
merged 1 commit into from Feb 10, 2014
Merged

<install> Changes for activemq-5.9.0 update - enterprise 2.0 #295

merged 1 commit into from Feb 10, 2014

Conversation

detiber
Copy link
Contributor

@detiber detiber commented Feb 7, 2014

Updated to work with previous activemq versions

@detiber
Copy link
Contributor Author

detiber commented Feb 7, 2014

@Miciah look good?

@brenton
Copy link
Contributor

brenton commented Feb 7, 2014

Jason and I had a conversation about this. Given that we now disable jetty by default as part of #293 I don't think we should even bother with all the other jetty configuration we were having to setup. We might want to make sure that PR works with our new activemq build though.

It seems reasonable for admins to consult the activemq documentation if they want to enable jetty securely. Our documentation will soon tell customer to disable the jetty service if they are installing by hand.

Therefore I think we can remove a lot of this complexity from our installation script. Our new activemq build will have the host attribute already set. There's nothing wrong with users that ran older versions of our installation script and had jetty enabled. This is just general hardening... turn off any service you don't need.

@detiber
Copy link
Contributor Author

detiber commented Feb 7, 2014

Updated to remove jetty and jetty realm configuration changes.

@detiber
<install> Remove the jetty and jetty realm configuration
9a9c2bf 
- Add comment to tell users that they should enable authentication and
  set passwords if enabling jetty.xml
jianlinliu added a commit that referenced this pull request Feb 10, 2014
@jianlinliu
Merge pull request #295 from detiber/2.0-activemq-5.9.0
719c7fd 
<install> Changes for activemq-5.9.0 update - enterprise 2.0
@jianlinliu jianlinliu merged commit 719c7fd into openshift:enterprise-2.0 Feb 10, 2014
@detiber detiber deleted the 2.0-activemq-5.9.0 branch November 8, 2014 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@detiber @brenton @jianlinliu