openshift.ks - add "EXTRA" repo vars for testing #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # If set, will define a yum repo under the yum,rhsm,rhn install | ||
| # methods. This will parallel the regular RHEL channels/repos at the | ||
| # same priority. The value of this option sets the "baseurl" setting | ||
| # for the defined repo. Useful for testing prerelease content |
There was a problem hiding this comment.
It's a sentence fragment, not a sentence. No full-stop required. :)
|
Looks fine notwithstanding my nitpicks that don't really matter. 👍 |
|
@dobbymoodge, Feel free to put the bug ON_QA with the link to this pull request. |
enterprise bug 1119419 https://bugzilla.redhat.com/show_bug.cgi?id=1119419 This adds options for setting up additional repos for jbosseap, jbossews, rhscl and rhel so we can test alpha/beta packages for channels we depend on.
jianlinliu
added a commit
that referenced
this pull request
Aug 5, 2014
openshift.ks - add "EXTRA" repo vars for testing
| { | ||
| extra_repo_file=/etc/yum.repos.d/ose_extra.repo | ||
| if [ -e "${extra_repo_file}" ]; then | ||
| echo > "${extra_repo_file}" |
There was a problem hiding this comment.
You can drop the echo and just use > "${extra_repo_file}" unless there is some reason to start with a blank line (in which case a comment would be helpful).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enterprise bug 1119419
https://bugzilla.redhat.com/show_bug.cgi?id=1119419
This adds options for setting up additional repos for jbosseap,
jbossews, rhscl and rhel so we can test alpha/beta packages for channels
we depend on.